Skip to content

Propagate module notifier errors

Peter Zijlstra live-patching lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v13 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4notifier: Fix broken error handling patterninclude/linux/notifier.h kernel/cpu_pm.c kernel/notifier.c +6 more+139 -1331 reply
2/4module: Fix up module_notifier return values.drivers/oprofile/buffer_sync.c kernel/trace/bpf_trace.c kernel/trace/trace.c +3 more+13 -91 reply
3/4module: Properly propagate MODULE_STATE_COMING failurekernel/module.c+7 -31 reply
4/4jump_label,module: Fix module lifetime for __jump_label_mod_text_reservedkernel/jump_label.c+8 -21 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchMathieu DesnoyersJoel Fernandes (Google)Robert RichterRafael J. WysockiSteven Rostedt (VMware)
1/4A-b
2/4R-b R-b R-b A-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] Propagate module notifier errors

These patches came from the desire to propagate MODULE_STATE_COMING errors. While looking at that I spotted fail with a number of module notifiers themselves and with the whole notification business.

I will probably add a notifier for MODULE_STATE_UNFORMED, but that is later.

Fixing this error propagation fixes a fairly serious (but really uncommon) bug when memory allocation fails for jump-labels while loading a module. And since we're going to be introducing more of that (static_call), fix it now.