Skip to content

Better PHYLINK compliance for SJA1105 DSA

Vladimir Oltean netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

- Removed redundant print in the phylink_validate callback (in 2/3).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: dsa: sja1105: Don't check state->link in phylink_mac_configdrivers/net/dsa/sja1105/sja1105_main.c+7 -40 replies
2/3net: dsa: sja1105: Check for PHY mode mismatches with what PHYLINK reportsdrivers/net/dsa/sja1105/sja1105_main.c+44 -00 replies
3/3net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINKdrivers/net/dsa/sja1105/sja1105_main.c+5 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRussell King
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/3] Better PHYLINK compliance for SJA1105 DSA

After discussing with Russell King, it appears this driver is making a few confusions and not performing some checks for consistent operation.

Changes in v2:
- Removed redundant print in the phylink_validate callback (in 2/3).

Vladimir Oltean (3):
net: dsa: sja1105: Don't check state->link in phylink_mac_config
net: dsa: sja1105: Check for PHY mode mismatches with what PHYLINK
reports
net: dsa: sja1105: Mark in-band AN modes not supported for PHYLINK

 drivers/net/dsa/sja1105/sja1105_main.c | 56 +++++++++++++++++++++++++-
 1 file changed, 54 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1