Skip to content

restrict bridge interface name to IFNAMSIZ

P J P qemu-devel 4 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 18 repliesApplied
  2. v33 patches 7 repliesSuperseded
  3. v23 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch6 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3qemu-bridge-helper: restrict interface name to IFNAMSIZqemu-bridge-helper.c+11 -03 replies
2/3qemu-bridge-helper: move repeating code in parse_acl_fileqemu-bridge-helper.c+9 -103 replies
3/3net: tap: replace snprintf with g_strdup_printf callsnet/tap.c+11 -89 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchStefan HajnocziDaniel P. BerrangéLi Qiang
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ

From: Prasad J Pandit <[email protected]>

Hello,

Linux net_deivce defines network interface name to be of IFNAMSIZE(=16) bytes, including the terminating null('\0') byte.

Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the network bridge interface, supplies bridge name of 16 characters, thus allowing to create an ACL bypass scenario.

This patch series attempts to fix it. It also updates bridge helper invocation routine 'net_bridge_run_helper' to avoid snprintf() calls.

Thank you.
--
Prasad J Pandit (3):
qemu-bridge-helper: restrict interface name to IFNAMSIZ
qemu-bridge-helper: move repeating code in parse_acl_file
net: tap: replace snprintf with g_strdup_printf calls

 net/tap.c            | 19 +++++++++++--------
 qemu-bridge-helper.c | 24 +++++++++++++++++-------
 2 files changed, 28 insertions(+), 15 deletions(-)
Signature · 1 line
2.21.0