make RB_DECLARE_CALLBACKS more generic
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 8 repliesIn review
- v23 patches 7 repliesSuperseded
- v12 patches 4 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | augmented rbtree: add comments for RB_DECLARE_CALLBACKS macroinclude/ tools/ | +66 | 0 replies | |
| 2/3 | augmented rbtree: add new RB_DECLARE_CALLBACKS_MAX macroarch/ drivers/ include/ +4 more | +99 | 7 replies | |
| 3/3 | augmented rbtree: rework the RB_DECLARE_CALLBACKS macro definitioninclude/ tools/ | +24 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Davidlohr Bueso | Peter Zijlstra (Intel) |
|---|---|---|
| Series | A-b | |
| 1/3 | A-b | |
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] make RB_DECLARE_CALLBACKS more generic
These changes are intended to make the RB_DECLARE_CALLBACKS macro more generic (allowing the aubmented subtree information to be a struct instead of a scalar).
Changes since v2: Left the RBSTATIC and RBNAME arguments first in the RB_DECLARE_CALLBACKS and RB_DECLARE_CALLBACKS_MAX macros as suggested by Peter Zijlstra.
Changes since v1: I have added a new RB_DECLARE_CALLBACKS_MAX macro, which generates augmented rbtree callbacks where the subtree information can be expressed as max(f(node)). This covers all current uses, and thus makes it easy to do the later RB_DECLARE_CALLBACKS definition change as it's only currently used in RB_DECLARE_CALLBACKS_MAX.
I have also verified the compiled lib/interval_tree.o and mm/mmap.o files to check that they didn't change. This held as expected for interval_tree.o; mmap.o did have some changes which could be reverted by marking __vma_link_rb as noinline. I did not add such a change to the patchset; I felt it was reasonable enough to let the inlining decision up to the compiler.
Michel Lespinasse (3):
augmented rbtree: add comments for RB_DECLARE_CALLBACKS macro augmented rbtree: add new RB_DECLARE_CALLBACKS_MAX macro augmented rbtree: rework the RB_DECLARE_CALLBACKS macro definition
arch/x86/mm/pat_rbtree.c | 19 +----- drivers/block/drbd/drbd_interval.c | 29 +-------- include/linux/interval_tree_generic.h | 22 +------ include/linux/rbtree_augmented.h | 88 ++++++++++++++++++++------ lib/rbtree_test.c | 22 +------ mm/mmap.c | 29 +++++---- tools/include/linux/rbtree_augmented.h | 88 ++++++++++++++++++++------ 7 files changed, 163 insertions(+), 134 deletions(-)
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog