drm: cec: convert DRM drivers to the new notifier API
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest9 patches 40 repliesApplied
- v68 patches 6 repliesSuperseded
- v59 patches 10 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 9 patches | 4 replies | Superseded | |
| v3 | 9 patches | 3 replies | Superseded | |
| v2 | 5 patches | 6 replies | Superseded | |
| v1 | 5 patches | 0 replies | Superseded |
Changes in v7 from the cover letter
Made CEC notifiers' registration and de-registration symmetric in tda998x and dw-hdmi drivers. Also, accidentally dropped one patch in v6 (change to drm_dp_cec), brought it back now.
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | drm_dp_cec: add connector info support.drivers/ drivers/ drivers/ +2 more | +27 | 6 replies | |
| 2/9 | drm/i915/intel_hdmi: use cec_notifier_conn_(un)registerdrivers/ | +9 | 3 replies | |
| 3/9 | dw-hdmi-cec: use cec_notifier_cec_adap_(un)registerdrivers/ | +6 | 2 replies | |
| 4/9 | tda9950: use cec_notifier_cec_adap_(un)registerdrivers/ | +6 | 0 replies | |
| 5/9 | drm: tda998x: use cec_notifier_conn_(un)registerdrivers/ | +25 | 3 replies | |
| 5/9 | drm: tda998x: use cec_notifier_conn_(un)registerdrivers/ | +25 | 0 replies | |
| 5/9 | drm: tda998x: use cec_notifier_conn_(un)registerdrivers/ | +26 | 0 replies | |
| 6/9 | drm: sti: use cec_notifier_conn_(un)registerdrivers/ | +12 | 3 replies | |
| 7/9 | drm: tegra: use cec_notifier_conn_(un)registerdrivers/ | +21 | 9 replies | |
| 8/9 | drm: dw-hdmi: use cec_notifier_conn_(un)registerdrivers/ | +30 | 6 replies | |
| 9/9 | drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)registerdrivers/ | +18 | 3 replies | |
| 9/9 | drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)registerdrivers/ | +18 | 0 replies |
Reviews trailers per patch
8 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Hans Verkuil | Lyude Paul | Neil Armstrong | Alex Deucher | Ben Skeggs | Ville Syrjälä | Sylwester Nawrocki | Thierry Reding |
|---|---|---|---|---|---|---|---|---|
| 1/9 | T-b | R-b | A-b | R-b | R-b | |||
| 2/9 | T-b | R-b | ||||||
| 3/9 | T-b | R-b | ||||||
| 4/9 | T-b | |||||||
| 5/9 | T-b T-b | |||||||
| 5/9 | T-b T-b | |||||||
| 5/9 | T-b T-b | |||||||
| 6/9 | A-b | |||||||
| 7/9 | T-b A-b | A-b | ||||||
| 8/9 | A-b T-b | R-b | ||||||
| 9/9 | T-b A-b T-b | R-b | ||||||
| 9/9 | T-b A-b T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.
Cover letter [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API
This series updates DRM drivers to use new CEC notifier API.
Changes since v6:
Made CEC notifiers' registration and de-registration symmetric in tda998x and dw-hdmi drivers. Also, accidentally dropped one patch in v6 (change to drm_dp_cec), brought it back now.
Changes since v5:
Fixed a warning about a missing comment for a new member of drm_dp_aux_cec struct. Sending to a wider audience, including maintainers of respective drivers.
Changes since v4:
Addressing review comments.
Changes since v3:
Updated adapter flags in dw-hdmi-cec.
Changes since v2:
Include all DRM patches from "cec: improve notifier support, add connector info connector info" series.
Changes since v1:
Those patches delay creation of notifiers until respective connectors are constructed. It seems that those patches, for a couple of drivers, by adding the delay, introduce a race between notifiers' creation and the IRQs handling threads - at least I don't see anything obvious in there that would explicitly forbid such races to occur. v2 adds a write barrier to make sure IRQ threads see the notifier once it is created (replacing the WRITE_ONCE I put in v1). The best thing to do here, I believe, would be not to have any synchronization and make sure that an IRQ only gets enabled after the notifier is created.
Dariusz Marcinkiewicz (9):
drm_dp_cec: add connector info support.
drm/i915/intel_hdmi: use cec_notifier_conn_(un)register
dw-hdmi-cec: use cec_notifier_cec_adap_(un)register
tda9950: use cec_notifier_cec_adap_(un)register
drm: tda998x: use cec_notifier_conn_(un)register
drm: sti: use cec_notifier_conn_(un)register
drm: tegra: use cec_notifier_conn_(un)register
drm: dw-hdmi: use cec_notifier_conn_(un)register
drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 +++--- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +++++++++++++------ drivers/gpu/drm/drm_dp_cec.c | 25 ++++++---- drivers/gpu/drm/exynos/exynos_hdmi.c | 31 +++++++------ drivers/gpu/drm/i2c/tda9950.c | 12 ++--- drivers/gpu/drm/i2c/tda998x_drv.c | 36 ++++++++++----- drivers/gpu/drm/i915/display/intel_dp.c | 4 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 13 ++++-- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +- drivers/gpu/drm/sti/sti_hdmi.c | 19 +++++--- drivers/gpu/drm/tegra/output.c | 28 ++++++++--- include/drm/drm_dp_helper.h | 17 ++++--- 13 files changed, 155 insertions(+), 94 deletions(-)
Signature · 1 line
2.23.0.rc1.153.gdeed80330f-goog