Skip to content

tools: mkenvimage: Fixes for reading from pipes

Andre Przywara u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] tools: mkenvimage: Fixes for reading from pipes

On Sun, 30 Jun 2019 10:40:44 -0400
Tom Rini <[email protected]> wrote:

Hi Tom,

Quoted 17 lines · Andre Przywara
Quoted 16 lines

This fixes two issues I had when trying to create an envimage from a more complex pipe:
- The read process stops when the read(2) syscall returns less bytes than requested.
- Specifying an input filename expects this to be a regular file.

See the respective commit messages for more details.

Thanks!
Andre

Andre Przywara (2):
tools: mkenvimage: Fix reading from slow pipe
tools: mkenvimage: Always consider non-regular files

Quoted 6 lines
Quoted 2 lines
 tools/mkenvimage.c | 71 ++++++++++++++++--------------------------------------
 1 file changed, 21 insertions(+), 50 deletions(-)  

These all look fine but in the interest of avoiding unintended consequences I'm going to pull these in after v2019.07 as they're long-standing bugs rather than regressions being fixed, thanks!

Thanks, that was my intention anyway.

So is the development model now "only send new changes/features in the merge window"? I was suspecting that with this new long stabilisation phase we prepare patches outside of the merge window? Or was the "Fixes ..." in the subject line giving the wrong impression of my intention?

Cheers,
Andre.