Skip to content

RFC Add support for text rendering

Yordan Karadzhov (VMware) linux-trace-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest5 patches 2 repliesIn review
  2. v1 RFC3 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- 2 new patches (patches 4/5 and 5/5).

- Added a procedure for finding a font file (patch 2/5).

- Addressed the comments made by Slavomir in his review of the previous version.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5kernel-shark: Simplify the drawing of the Triangle Fankernel-shark/src/libkshark-plot.c+1 -100 replies
2/5kernel-shark: Add support for drawing textkernel-shark/doc/dox_config kernel-shark/src/libkshark-plot.c kernel-shark/src/libkshark-plot.h +1 more+5137 -30 replies
3/5kernel-shark: Add text rendering to the plotting examplekernel-shark/examples/dataplot.cpp+11 -00 replies
4/5kernel-shark: Add hello_kernel pluginkernel-shark/examples/CMakeLists.txt kernel-shark/examples/hello_kernel.c kernel-shark/src/libkshark-plugin.h+74 -00 replies
5/5kernel-shark: Drop Freeglut as a compulsory dependencykernel-shark/build/deff.h.cmake kernel-shark/examples/CMakeLists.txt kernel-shark/src/CMakeLists.txt +4 more+21 -231 reply

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSlavomir Kaslev
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH v2 0/5] Add support for text rendering

Implemented using the single-file public domain library "stb_truetype":
https://github.com/nothings/stb/blob/master/stb_truetype.h

PS: Patch 1/3 is a simple fix suggested by Slavomir which strictly speaking is independent from the other two patches.

v2 changes:
- 2 new patches (patches 4/5 and 5/5).

- Added a procedure for finding a font file (patch 2/5).

- Addressed the comments made by Slavomir in his review of the previous version.

Yordan Karadzhov (VMware) (5):
kernel-shark: Simplify the drawing of the Triangle Fan
kernel-shark: Add support for drawing text
kernel-shark: Add text rendering to the plotting example
kernel-shark: Add hello_kernel plugin
kernel-shark: Drop Freeglut as a compulsory dependency

 kernel-shark/build/deff.h.cmake      |    3 +
 kernel-shark/doc/dox_config          |    1 +
 kernel-shark/examples/CMakeLists.txt |   14 +-
 kernel-shark/examples/dataplot.cpp   |   11 +
 kernel-shark/examples/hello_kernel.c |   67 +
 kernel-shark/src/CMakeLists.txt      |    4 +-
 kernel-shark/src/KsGLWidget.cpp      |    4 -
 kernel-shark/src/KsPlotTools.cpp     |    4 -
 kernel-shark/src/libkshark-plot.c    |  239 +-
 kernel-shark/src/libkshark-plot.h    |   46 +
 kernel-shark/src/libkshark-plugin.h  |    3 +
 kernel-shark/src/stb_truetype.h      | 4882 ++++++++++++++++++++++++++
 12 files changed, 5243 insertions(+), 35 deletions(-)
 create mode 100644 kernel-shark/examples/hello_kernel.c
 create mode 100644 kernel-shark/src/stb_truetype.h
Signature · 1 line
2.20.1