Skip to content

hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child()

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-trivial 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 12 repliesIn review
  2. v16 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/arm: Use ARM_CPU_TYPE_NAME() macro when appropriatehw/arm/allwinner-a10.c hw/arm/cubieboard.c hw/arm/digic.c +5 more+15 -111 reply
2/6hw/arm: Use object_initialize_child for correct reference countinghw/arm/mcimx7d-sabre.c hw/arm/mps2-tz.c hw/arm/musca.c+16 -172 replies
3/6hw/arm: Use sysbus_init_child_obj for correct reference countinghw/arm/exynos4_boards.c+2 -23 replies
4/6hw/arm/fsl-imx: Add the cpu as child of the SoC objecthw/arm/fsl-imx25.c hw/arm/fsl-imx31.c+6 -21 reply
5/6hw/dma/xilinx_axi: Use object_initialize_child for correct ref. countinghw/dma/xilinx_axidma.c+8 -82 replies
6/6hw/net/xilinx_axi: Use object_initialize_child for correct ref. countinghw/net/xilinx_axienet.c+8 -92 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisPeter MaydellThomas HuthRichard Henderson
1/6R-b R-b
2/6R-b R-b R-b
3/6R-b
4/6R-b
5/6R-b R-b R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [Qemu-arm] [PATCH v2 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child()

First we use ARM_CPU_TYPE_NAME() when we should.

Then is follow up of [1]:

This series looks at Eduardo suggestions from [2] and Thomas commit aff39be0ed97 to replace various object_initialize + qdev_set_parent_bus calls by sysbus_init_child_obj().

Finally, some devices are declared orphean while they have a parent, let them be together again.

Since v1 [3]:
- addressed Peter Maydell review comments

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01492.html
[2] https://patchwork.ozlabs.org/patch/943333/#1953608
[3] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg00135.html

Philippe Mathieu-Daudé (6):
hw/arm: Use ARM_CPU_TYPE_NAME() macro when appropriate hw/arm: Use object_initialize_child for correct reference counting hw/arm: Use sysbus_init_child_obj for correct reference counting hw/arm/fsl-imx: Add the cpu as child of the SoC object hw/dma/xilinx_axi: Use object_initialize_child for correct ref.
counting
hw/net/xilinx_axi: Use object_initialize_child for correct ref.
counting

 hw/arm/allwinner-a10.c  |  3 ++-
 hw/arm/cubieboard.c     |  3 ++-
 hw/arm/digic.c          |  3 ++-
 hw/arm/exynos4_boards.c |  4 ++--
 hw/arm/fsl-imx25.c      |  4 +++-
 hw/arm/fsl-imx31.c      |  4 +++-
 hw/arm/fsl-imx6.c       |  3 ++-
 hw/arm/fsl-imx6ul.c     |  2 +-
 hw/arm/mcimx7d-sabre.c  |  9 ++++-----
 hw/arm/mps2-tz.c        | 15 +++++++--------
 hw/arm/musca.c          |  9 +++++----
 hw/arm/xlnx-zynqmp.c    |  8 ++++----
 hw/dma/xilinx_axidma.c  | 16 ++++++++--------
 hw/net/xilinx_axienet.c | 17 ++++++++---------
 14 files changed, 53 insertions(+), 47 deletions(-)
Signature · 1 line
2.20.1