Skip to content

tools: mkenvimage: Fixes for reading from pipes

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20190701132326.GH9388@bill-the-cat

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tools: mkenvimage: Fix reading from slow pipe+0 -00 replies
2/2tools: mkenvimage: Always consider non-regular files+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] tools: mkenvimage: Fixes for reading from pipes
Quoted 29 lines · Andre Przywara

On Sun, 30 Jun 2019 10:40:44 -0400
Tom Rini <[email protected]> wrote:

Hi Tom,

Quoted 17 lines · Andre Przywara
Quoted 16 lines

This fixes two issues I had when trying to create an envimage from a more complex pipe:
- The read process stops when the read(2) syscall returns less bytes than requested.
- Specifying an input filename expects this to be a regular file.

See the respective commit messages for more details.

Thanks!
Andre

Andre Przywara (2):
tools: mkenvimage: Fix reading from slow pipe
tools: mkenvimage: Always consider non-regular files

Quoted 6 lines
Quoted 2 lines
 tools/mkenvimage.c | 71 ++++++++++++++++--------------------------------------
 1 file changed, 21 insertions(+), 50 deletions(-)  

These all look fine but in the interest of avoiding unintended consequences I'm going to pull these in after v2019.07 as they're long-standing bugs rather than regressions being fixed, thanks!

Quoted 7 lines

Thanks, that was my intention anyway.

So is the development model now "only send new changes/features in the merge window"? I was suspecting that with this new long stabilisation phase we prepare patches outside of the merge window?
Or was the "Fixes ..." in the subject line giving the wrong impression of my intention?

New changes / features should still be posted when they're ready for public review, to get the most possible review done to them. I just figured that since this was a series that was fixing a problem I should give it a look and since I could see an argument in favor of merging them now, say why I wasn't.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190701/1d9b6087/attachment.sig>