Skip to content

qapi: block-dirty-bitmap-remove transaction action

John Snow qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my bitmaps tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 10 repliesApplied
  2. v23 patches 3 repliesSuperseded

Changes in v3 from the cover letter

===

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3blockdev: reduce aio_context locked sections in bitmap add/removeblockdev.c+13 -171 reply
2/3qapi: implement block-dirty-bitmap-remove transaction actionblock.c block/dirty-bitmap.c blockdev.c +3 more+85 -174 replies
3/3iotests: test bitmap moving inside 254tests/qemu-iotests/254 tests/qemu-iotests/254.out+110 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJohn SnowMax Reitz
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/3] qapi: block-dirty-bitmap-remove transaction action

Hi, this is a proposal based off of Vladimir's patchset:
[Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action

===
V3:
===

001/3:[----] [--] 'blockdev: reduce aio_context locked sections in bitmap add/remove' 002/3:[0024] [FC] 'qapi: implement block-dirty-bitmap-remove transaction action' 003/3:[----] [--] 'iotests: test bitmap moving inside 254'

- Changed "squelch_persistence" to "skip_store"
- Use Max's suggestion for return expr

===
V2:
===

It replaces patches two and three with a modified patch (now patch 2) that foregoes the need for a hide()/unhide() bitmap API. I think it's suitable as a smaller alternative, but I'm not sure if it covers all of the use cases of the original series.

Patches 1 and 3 (formerly 4) included as-is.

John Snow (1):
qapi: implement block-dirty-bitmap-remove transaction action

Vladimir Sementsov-Ogievskiy (2):
blockdev: reduce aio_context locked sections in bitmap add/remove
iotests: test bitmap moving inside 254

 block.c                        |   2 +-
 block/dirty-bitmap.c           |  15 +++--
 blockdev.c                     | 105 ++++++++++++++++++++++++++-------
 include/block/dirty-bitmap.h   |   2 +-
 migration/block-dirty-bitmap.c |   2 +-
 qapi/transaction.json          |   2 +
 tests/qemu-iotests/254         |  30 +++++++++-
 tests/qemu-iotests/254.out     |  82 +++++++++++++++++++++++++
 8 files changed, 206 insertions(+), 34 deletions(-)
Signature · 1 line
2.21.0