Skip to content

cleanup cppcheck warnings for fm10k driver

Jacob Keller intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19fm10k: reduce scope of the err variabledrivers/net/ethernet/intel/fm10k/fm10k_dcbnl.c+3 -31 reply
2/19fm10k: reduce scope of *p local variabledrivers/net/ethernet/intel/fm10k/fm10k_ethtool.c+2 -31 reply
3/19fm10k: reduce the scope of qv local variabledrivers/net/ethernet/intel/fm10k/fm10k_ethtool.c+2 -21 reply
4/19fm10k: reduce the scope of local err variabledrivers/net/ethernet/intel/fm10k/fm10k_iov.c+3 -21 reply
5/19fm10k: reduce the scope of the q_idx local variabledrivers/net/ethernet/intel/fm10k/fm10k_main.c+5 -41 reply
6/19fm10k: reduce the scope of the tx_buffer variabledrivers/net/ethernet/intel/fm10k/fm10k_netdev.c+2 -21 reply
7/19fm10k: reduce the scope of the err variabledrivers/net/ethernet/intel/fm10k/fm10k_pci.c+3 -21 reply
8/19fm10k: reduce the scope of the local i variabledrivers/net/ethernet/intel/fm10k/fm10k_pci.c+2 -21 reply
9/19fm10k: reduce the scope of the local msg variabledrivers/net/ethernet/intel/fm10k/fm10k_mbx.c+4 -21 reply
10/19fm10k: reduce the scope of the result local variabledrivers/net/ethernet/intel/fm10k/fm10k_pf.c+1 -21 reply
11/19fm10k: reduce scope of the ring variabledrivers/net/ethernet/intel/fm10k/fm10k_netdev.c+2 -21 reply
12/19fm10k: remove unnecessary variable initializerdrivers/net/ethernet/intel/fm10k/fm10k_tlv.c+1 -11 reply
13/19fm10k: remove needless assignment of err local variabledrivers/net/ethernet/intel/fm10k/fm10k_netdev.c+5 -51 reply
14/19fm10k: remove needless initialization of size local variabledrivers/net/ethernet/intel/fm10k/fm10k_netdev.c+1 -11 reply
15/19fm10k: explicitly return 0 on success path in functiondrivers/net/ethernet/intel/fm10k/fm10k_pci.c+1 -11 reply
16/19fm10k: cast page_addr to u8 * when incrementing itdrivers/net/ethernet/intel/fm10k/fm10k_main.c+1 -11 reply
17/19fm10k: mark unused parameters with __always_unuseddrivers/net/ethernet/intel/fm10k/fm10k_mbx.c drivers/net/ethernet/intel/fm10k/fm10k_pf.c drivers/net/ethernet/intel/fm10k/fm10k_tlv.c +2 more+28 -211 reply
18/19fm10k: convert NON_Q_VECTORS(hw) into NON_Q_VECTORSdrivers/net/ethernet/intel/fm10k/fm10k.h drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c drivers/net/ethernet/intel/fm10k/fm10k_main.c +1 more+11 -181 reply
19/19fm10k: fix fm10k_get_fault_pf to read correct addressdrivers/net/ethernet/intel/fm10k/fm10k_pf.c+1 -11 reply

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by.

PatchAndrew Bowers
1/19T-b
2/19T-b
3/19T-b
4/19T-b
5/19T-b
6/19T-b
7/19T-b
8/19T-b
9/19T-b
10/19T-b
11/19T-b
12/19T-b
13/19T-b
14/19T-b
15/19T-b
16/19T-b
17/19T-b
18/19T-b
19/19T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH 00/19] cleanup cppcheck warnings for fm10k driver

This series contains several patches which resolve various warnings generated by using the cppcheck tool on the fm10k driver source code.

The most comment fix is to reduce the scope of local variables where possible, and the first 10 patches fix issues like this.

The remaining 9 patches fix other issues found by the tool. Only one of the patches contains what is likely a bug fix. Specifically, the last patch in the series fixes a 64-bit register read issue where we failed to bitwise or the high and low registers together. As this is only in the reporting flow for fault detection, it is relatively minor.

This series does not fix all of the cppcheck warnings:

[fm10k_ethtool.c:332]: (style) Argument 'idx!=29' to function BUG_ON is always 0

This warning is due to the fact that we can't use BUILD_BUG_ON. cppcheck is smart enough to realize that the index will always be 29, and thus that BUG_ON will never be triggered.

[fm10k_mbx.c:335] -> [fm10k_mbx.c:356]: (style) Variable 'head' is reassigned a value before the old one has been used. [fm10k_mbx.c:350] -> [fm10k_mbx.c:356]: (style) Variable 'head' is reassigned a value before the old one has been used. [fm10k_mbx.c:428] -> [fm10k_mbx.c:442]: (style) Variable 'tail' is reassigned a value before the old one has been used. [fm10k_mbx.c:439] -> [fm10k_mbx.c:442]: (style) Variable 'tail' is reassigned a value before the old one has been used.

These are almost certainly due to a bug in cppcheck analysis. The head and tail values are assigned initially outside the loop. Then, they're updated in the for loop. However, they aren't updated until the end of the *first* for-loop iteration. I think cppcheck doesn't understand this and thus assumes that the value will be overwritten before its first use.

Jacob Keller (19):
fm10k: reduce scope of the err variable
fm10k: reduce scope of *p local variable
fm10k: reduce the scope of qv local variable
fm10k: reduce the scope of local err variable
fm10k: reduce the scope of the q_idx local variable
fm10k: reduce the scope of the tx_buffer variable
fm10k: reduce the scope of the err variable
fm10k: reduce the scope of the local i variable
fm10k: reduce the scope of the local msg variable
fm10k: reduce the scope of the result local variable
fm10k: reduce scope of the ring variable
fm10k: remove unnecessary variable initializer
fm10k: remove needless assignment of err local variable
fm10k: remove needless initialization of size local variable
fm10k: explicitly return 0 on success path in function
fm10k: cast page_addr to u8 * when incrementing it
fm10k: mark unused parameters with __always_unused
fm10k: convert NON_Q_VECTORS(hw) into NON_Q_VECTORS
fm10k: fix fm10k_get_fault_pf to read correct address

 drivers/net/ethernet/intel/fm10k/fm10k.h      | 10 +++-----
 .../net/ethernet/intel/fm10k/fm10k_dcbnl.c    |  6 ++---
 .../net/ethernet/intel/fm10k/fm10k_ethtool.c  | 15 +++++------
 drivers/net/ethernet/intel/fm10k/fm10k_iov.c  |  5 ++--
 drivers/net/ethernet/intel/fm10k/fm10k_main.c | 15 +++++------
 drivers/net/ethernet/intel/fm10k/fm10k_mbx.c  | 11 +++++---
 .../net/ethernet/intel/fm10k/fm10k_netdev.c   | 20 +++++++--------
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  | 20 +++++++--------
 drivers/net/ethernet/intel/fm10k/fm10k_pf.c   | 15 ++++++-----
 drivers/net/ethernet/intel/fm10k/fm10k_tlv.c  |  9 ++++---
 drivers/net/ethernet/intel/fm10k/fm10k_type.h |  2 +-
 drivers/net/ethernet/intel/fm10k/fm10k_vf.c   | 25 +++++++++++--------
 12 files changed, 78 insertions(+), 75 deletions(-)
Signature · 1 line
2.22.0.214.g8dca754b1e87