Skip to content

Fixes needed befor KS 1.0

Yordan Karadzhov (VMware) linux-trace-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8kernel-shark: Don't free the string field of KS_CONFIG_STRING documentkernel-shark/src/libkshark-configio.c+0 -10 replies
2/8kernel-shark: Add method for getting all selected eventskernel-shark/src/KsWidgetsLib.cpp kernel-shark/src/KsWidgetsLib.hpp+43 -00 replies
3/8kernel-shark: Optimize the command line options used by the capture dialogkernel-shark/src/KsCaptureDialog.cpp+6 -150 replies
4/8kernel-shark: Don't try to open data file if recording failedkernel-shark/src/KsCaptureDialog.cpp kernel-shark/src/KsCaptureDialog.hpp+11 -10 replies
5/8kernel-shark: Remove a duplicate error messagekernel-shark/src/KsMainWindow.cpp+0 -260 replies
6/8kernel-shark: remove the "make install" suggestion for capture errorskernel-shark/src/KsMainWindow.cpp+0 -21 reply
7/8kernel-shark: Disconnect "capture errors" before closing KernelShark GUIkernel-shark/src/KsMainWindow.cpp kernel-shark/src/KsMainWindow.hpp+15 -20 replies
8/8kernel-shark: Less scary error message from Capture dialogkernel-shark/src/KsCaptureDialog.cpp+4 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8]Fixes needed befor KS 1.0

Bug fixes and optimizations for the Capture dialog of KernelShark.

Yordan Karadzhov (VMware) (8):
kernel-shark: Don't free the string field of KS_CONFIG_STRING document
kernel-shark: Add method for getting all selected events
kernel-shark: Optimize the command line options used by the capture
dialog
kernel-shark: Don't try to open data file if recording failed
kernel-shark: Remove a duplicate error message
kernel-shark: remove the "make install" suggestion for capture errors
kernel-shark: Disconnect "capture errors" before closing KernelShark
GUI
kernel-shark: Less scary error message from Capture dialog

 kernel-shark/src/KsCaptureDialog.cpp  | 36 +++++++++++-----------
 kernel-shark/src/KsCaptureDialog.hpp  |  2 ++
 kernel-shark/src/KsMainWindow.cpp     | 43 ++++++++-------------------
 kernel-shark/src/KsMainWindow.hpp     |  2 ++
 kernel-shark/src/KsWidgetsLib.cpp     | 41 +++++++++++++++++++++++++
 kernel-shark/src/KsWidgetsLib.hpp     |  2 ++
 kernel-shark/src/libkshark-configio.c |  1 -
 7 files changed, 79 insertions(+), 48 deletions(-)
Signature · 1 line
2.20.1