Skip to content

MCR fixes and more

Tvrtko Ursulin intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 11 repliesIn review
  2. v14 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/i915: Fix GEN8_MCR_SELECTOR programmingdrivers/gpu/drm/i915/gt/intel_engine_cs.c+7 -23 replies
2/6drm/i915: Trust programmed MCR in read_subslice_regdrivers/gpu/drm/i915/gt/intel_engine_cs.c+12 -253 replies
3/6drm/i915: Fix and improve MCR selection logicdrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/i915_drv.h+49 -672 replies
4/6drm/i915: Skip CS verification of L3 bank registersdrivers/gpu/drm/i915/gt/intel_workarounds.c+33 -51 reply
5/6drm/i915/icl: Verify engine workarounds in GEN8_L3SQCREG4drivers/gpu/drm/i915/gt/intel_workarounds.c+6 -210 replies
6/6drm/i915/icl: Add Wa_1409178092drivers/gpu/drm/i915/gt/intel_workarounds.c drivers/gpu/drm/i915/i915_reg.h+9 -01 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchChris WilsonStuart Summers
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] MCR fixes and more

From: Tvrtko Ursulin <[email protected]>

A few bugs in programming the MCR register sneaked in past code review.

First of all fls() usage is wrong and suffers from off-by-one problem.

Secondly the assert in WaProgramMgsrForL3BankSpecificMmioReads is also wrong due inverted logic.

With MCR programming fixed we can stop ignoring the engine workarounds verification of GEN8_L3SQCREG4. But not registers in the 0xb100-0xb3ff range which cannot be read reliably by the command streamers.

The logic is also improved to not only assert when static MCR configuration would not work given specific subslice and L3 bank configuration, but to find a valid static configuration if possible.

Finally there was a missing perfomance based workaround which loosely belongs to this overall story of ICL, subslices, L3 banks and workarounds.

Tvrtko Ursulin (6):
drm/i915: Fix GEN8_MCR_SELECTOR programming drm/i915: Trust programmed MCR in read_subslice_reg drm/i915: Fix and improve MCR selection logic drm/i915: Skip CS verification of L3 bank registers drm/i915/icl: Verify engine workarounds in GEN8_L3SQCREG4 drm/i915/icl: Add Wa_1409178092

 drivers/gpu/drm/i915/gt/intel_engine_cs.c   |  56 ++-----
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 161 ++++++++++++--------
 drivers/gpu/drm/i915/i915_drv.h             |   2 -
 drivers/gpu/drm/i915/i915_reg.h             |   3 +
 4 files changed, 109 insertions(+), 113 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx