Skip to content

RFC Try to reduce lock contention on the SMMUv3 command queue

Will Deacon linux-iommu 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 RFC Latest19 patches 17 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19iommu: Remove empty iommu_tlb_range_add() callback from iommu_opsdrivers/iommu/amd_iommu.c drivers/iommu/iommu.c drivers/vfio/vfio_iommu_type1.c +1 more+0 -250 replies
2/19iommu/io-pgtable-arm: Remove redundant call to io_pgtable_tlb_sync()drivers/iommu/io-pgtable-arm-v7s.c drivers/iommu/io-pgtable-arm.c+0 -20 replies
3/19iommu/io-pgtable: Rename iommu_gather_ops to iommu_flush_opsdrivers/gpu/drm/panfrost/panfrost_mmu.c drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c +7 more+20 -200 replies
4/19iommu: Introduce struct iommu_iotlb_gather for batching TLB flushesdrivers/iommu/dma-iommu.c drivers/iommu/iommu.c drivers/vfio/vfio_iommu_type1.c +1 more+75 -223 replies
5/19iommu: Introduce iommu_iotlb_gather_add_page()include/linux/iommu.h+31 -00 replies
6/19iommu: Pass struct iommu_iotlb_gather to ->unmap() and ->iotlb_sync()drivers/iommu/amd_iommu.c drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c +14 more+70 -310 replies
7/19iommu/io-pgtable: Introduce tlb_flush_walk() and tlb_flush_leaf()include/linux/io-pgtable.h+19 -50 replies
8/19iommu/io-pgtable: Hook up ->tlb_flush_walk() and ->tlb_flush_leaf() in driversdrivers/gpu/drm/panfrost/panfrost_mmu.c drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c +4 more+116 -00 replies
9/19iommu/io-pgtable-arm: Call ->tlb_flush_walk() and ->tlb_flush_leaf()drivers/iommu/io-pgtable-arm-v7s.c drivers/iommu/io-pgtable-arm.c include/linux/io-pgtable.h+41 -150 replies
10/19iommu/io-pgtable: Replace ->tlb_add_flush() with ->tlb_add_page()drivers/gpu/drm/panfrost/panfrost_mmu.c drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c +7 more+105 -710 replies
11/19iommu/io-pgtable: Remove unused ->tlb_sync() callbackdrivers/gpu/drm/panfrost/panfrost_mmu.c drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c +7 more+16 -540 replies
12/19iommu/io-pgtable: Pass struct iommu_iotlb_gather to ->unmap()drivers/gpu/drm/panfrost/panfrost_mmu.c drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c +7 more+16 -150 replies
13/19iommu/io-pgtable: Pass struct iommu_iotlb_gather to ->tlb_add_page()drivers/iommu/arm-smmu-v3.c drivers/iommu/arm-smmu.c drivers/iommu/io-pgtable-arm-v7s.c +5 more+47 -290 replies
14/19iommu/arm-smmu-v3: Separate s/w and h/w views of prod and cons indexesdrivers/iommu/arm-smmu-v3.c+22 -140 replies
15/19iommu/arm-smmu-v3: Drop unused 'q' argument from Q_OVF macrodrivers/iommu/arm-smmu-v3.c+6 -60 replies
16/19iommu/arm-smmu-v3: Move low-level queue fields out of arm_smmu_queuedrivers/iommu/arm-smmu-v3.c+47 -410 replies
17/19iommu/arm-smmu-v3: Operate directly on low-level queue where possibledrivers/iommu/arm-smmu-v3.c+31 -270 replies
18/19iommu/arm-smmu-v3: Reduce contention during command-queue insertiondrivers/iommu/arm-smmu-v3.c+529 -1447 replies
19/19iommu/arm-smmu-v3: Defer TLB invalidation until ->iotlb_sync()drivers/iommu/arm-smmu-v3.c+42 -290 replies

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by.

PatchGanapatrao Kulkarni
SeriesT-b
1/19
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [RFC PATCH v2 00/19] Try to reduce lock contention on the SMMUv3 command queue

Hi everyone,

This is a significant rework of the RFC I previously posted here:

https://lkml.kernel.org/r/[email protected]

But this time, it looks like it might actually be worthwhile according to my perf profiles, where __iommu_unmap() falls a long way down the profile for a multi-threaded netperf run. I'm still relying on others to confirm this is useful, however.

Some of the changes since last time are:

* Support for constructing and submitting a list of commands in the driver

* Numerous changes to the IOMMU and io-pgtable APIs so that we can submit commands in batches

* Removal of cmpxchg() from cmdq_shared_lock() fast-path

* Code restructuring and cleanups

This current applies against my iommu/devel branch that Joerg has pulled for 5.3. If you want to test it out, I've put everything here:

https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=iommu/cmdq

Feedback welcome. I appreciate that we're in the merge window, but I wanted to get this on the list for people to look at as an RFC.

Cheers,

Will

--->8

Cc Jean-Philippe Brucker <[email protected]>
Cc Robin Murphy <[email protected]>
Cc Jayachandran Chandrasekharan Nair <[email protected]>
Cc Jan Glauber <[email protected]>
Cc Jon Masters <[email protected]>
Cc Eric Auger <[email protected]>
Cc Zhen Lei <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Vijay Kilary <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc John Garry <[email protected]>
Cc Alex Williamson <[email protected]>

Will Deacon (19):
iommu: Remove empty iommu_tlb_range_add() callback from iommu_ops iommu/io-pgtable-arm: Remove redundant call to io_pgtable_tlb_sync() iommu/io-pgtable: Rename iommu_gather_ops to iommu_flush_ops
iommu: Introduce struct iommu_iotlb_gather for batching TLB flushes
iommu: Introduce iommu_iotlb_gather_add_page()
iommu: Pass struct iommu_iotlb_gather to ->unmap() and ->iotlb_sync() iommu/io-pgtable: Introduce tlb_flush_walk() and tlb_flush_leaf() iommu/io-pgtable: Hook up ->tlb_flush_walk() and ->tlb_flush_leaf() in
drivers
iommu/io-pgtable-arm: Call ->tlb_flush_walk() and ->tlb_flush_leaf() iommu/io-pgtable: Replace ->tlb_add_flush() with ->tlb_add_page() iommu/io-pgtable: Remove unused ->tlb_sync() callback iommu/io-pgtable: Pass struct iommu_iotlb_gather to ->unmap() iommu/io-pgtable: Pass struct iommu_iotlb_gather to ->tlb_add_page() iommu/arm-smmu-v3: Separate s/w and h/w views of prod and cons indexes iommu/arm-smmu-v3: Drop unused 'q' argument from Q_OVF macro iommu/arm-smmu-v3: Move low-level queue fields out of arm_smmu_queue iommu/arm-smmu-v3: Operate directly on low-level queue where possible iommu/arm-smmu-v3: Reduce contention during command-queue insertion iommu/arm-smmu-v3: Defer TLB invalidation until ->iotlb_sync()

 drivers/gpu/drm/panfrost/panfrost_mmu.c |  24 +-
 drivers/iommu/amd_iommu.c               |  11 +-
 drivers/iommu/arm-smmu-v3.c             | 856 ++++++++++++++++++++++++--------
 drivers/iommu/arm-smmu.c                | 103 +++-
 drivers/iommu/dma-iommu.c               |   9 +-
 drivers/iommu/exynos-iommu.c            |   3 +-
 drivers/iommu/intel-iommu.c             |   3 +-
 drivers/iommu/io-pgtable-arm-v7s.c      |  57 +--
 drivers/iommu/io-pgtable-arm.c          |  48 +-
 drivers/iommu/iommu.c                   |  24 +-
 drivers/iommu/ipmmu-vmsa.c              |  28 +-
 drivers/iommu/msm_iommu.c               |  42 +-
 drivers/iommu/mtk_iommu.c               |  45 +-
 drivers/iommu/mtk_iommu_v1.c            |   3 +-
 drivers/iommu/omap-iommu.c              |   2 +-
 drivers/iommu/qcom_iommu.c              |  44 +-
 drivers/iommu/rockchip-iommu.c          |   2 +-
 drivers/iommu/s390-iommu.c              |   3 +-
 drivers/iommu/tegra-gart.c              |  12 +-
 drivers/iommu/tegra-smmu.c              |   2 +-
 drivers/vfio/vfio_iommu_type1.c         |  27 +-
 include/linux/io-pgtable.h              |  57 ++-
 include/linux/iommu.h                   |  92 +++-
 23 files changed, 1090 insertions(+), 407 deletions(-)
Signature · 6 lines
2.11.0

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu