Skip to content

redundant rte_vdev_driver declarations

Stephen Hemminger dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net/tap: remove redundant declarationsdrivers/net/tap/rte_eth_tap.c+0 -21 reply
2/9net/af_packet: remove redundant rte_vdev_driver declarationdrivers/net/af_packet/rte_eth_af_packet.c+0 -20 replies
3/9net/vhost: remove redundant rte_vdev_driver declarationdrivers/net/vhost/rte_eth_vhost.c+0 -20 replies
4/9net/null: remove redundant rte_vdev_driver declarationdrivers/net/null/rte_eth_null.c+0 -20 replies
5/9net/pcap: remove redundant rte_vdev_driver declarationdrivers/net/pcap/rte_eth_pcap.c+0 -21 reply
6/9net/ring: remove redundant rte_vdev_drive declarationdrivers/net/ring/rte_eth_ring.c+0 -21 reply
7/9net/virtio_user: remove redundant rte_vdev_driver declarationdrivers/net/virtio/virtio_user_ethdev.c+0 -20 replies
8/9raw/skeleton_rawdev: remove redundant rte_vdev_driver declarationdrivers/raw/skeleton_rawdev/skeleton_rawdev.c+0 -30 replies
9/9raw/dpaa2_cmif: remove redundant rte_vdev_driver declarationdrivers/raw/dpaa2_cmdif/dpaa2_cmdif.c+0 -30 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKeith WilesBruce RichardsonFerruh Yigit
SeriesR-b
1/9A-b
2/9
3/9
4/9
5/9A-b
6/9A-b
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations

Many drivers declare the local rte_vdev_driver structure multiple times. This is unnecessary.

Surprised it is so common, I guess everyone copies the same code.

Stephen Hemminger (9):
net/tap: remove redundant declarations
net/af_packet: remove redundant rte_vdev_driver declaration net/vhost: remove redundant rte_vdev_driver declaration net/null: remove redundant rte_vdev_driver declaration net/pcap: remove redundant rte_vdev_driver declaration net/ring: remove redundant rte_vdev_drive declaration net/virtio_user: remove redundant rte_vdev_driver declaration raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration

 drivers/net/af_packet/rte_eth_af_packet.c     | 2 --
 drivers/net/null/rte_eth_null.c               | 2 --
 drivers/net/pcap/rte_eth_pcap.c               | 2 --
 drivers/net/ring/rte_eth_ring.c               | 2 --
 drivers/net/tap/rte_eth_tap.c                 | 2 --
 drivers/net/vhost/rte_eth_vhost.c             | 2 --
 drivers/net/virtio/virtio_user_ethdev.c       | 2 --
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c         | 3 ---
 drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 ---
 9 files changed, 20 deletions(-)
Signature · 1 line
2.20.1