Add Aspeed GPIO controller model
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 0 repliesNew
- v53 patches 5 repliesSuperseded
- v4 posting 2/20 of 3 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 posting 1/2 | 3 patches | 4 replies | Superseded | |
| v3 | 3 patches | 6 replies | Superseded | |
| v1 | 2 patches | 1 reply | Superseded |
Changes in v6 from the cover letter
- fixed bug in get/set pin
- added error checking that Cédric suggested
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500hw/ hw/ include/ | +983 | 0 replies | |
| 2/3 | aspeed: add a GPIO controller to the SoChw/ include/ | +20 | 0 replies | |
| 3/3 | hw/gpio: Add in AST2600 specific implementationhw/ | +137 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Cédric Le Goater | Andrew Jeffery |
|---|---|---|
| 1/3 | R-b | T-b |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-arm] [PATCH v6 0/3] Add Aspeed GPIO controller model
v6:
- fixed bug in get/set pin
- added error checking that Cédric suggested
v5:
- integrated AspeedGPIOController fields into AspeedGPIOClass
- separated ast2600_3_6v and ast2600_1_8v into two classes
v4:
- proper interupt handling thanks to Andrew
- switch statements for reading and writing suggested by Peter
- some small cleanups suggested by Alexey
v3:
- didn't have each gpio set up as an irq
- now can't access set AC on ast2400 (only exists on ast2500)
- added ast2600 implementation (patch 3)
- renamed a couple of variables for clarity
v2: Addressed Andrew's feedback, added debounce regs, renamed get/set to read/write to minimise confusion with a 'set' of registers.
Rashmica Gupta (3):
hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500
aspeed: add a GPIO controller to the SoC
hw/gpio: Add in AST2600 specific implementation
include/hw/arm/aspeed_soc.h | 3 + include/hw/gpio/aspeed_gpio.h | 100 ++++ hw/arm/aspeed_soc.c | 17 + hw/gpio/aspeed_gpio.c | 1014 +++++++++++++++++++++++++++++++++ hw/gpio/Makefile.objs | 1 + 5 files changed, 1135 insertions(+) create mode 100644 include/hw/gpio/aspeed_gpio.h create mode 100644 hw/gpio/aspeed_gpio.c
Signature · 1 line
2.20.1