Skip to content

Add Aspeed GPIO controller model

Rashmica Gupta qemu-arm qemu-devel 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 0 repliesNew
  2. v53 patches 5 repliesSuperseded
  3. v4 posting 2/20 of 3 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 posting 1/23 patches4 repliesSuperseded
v33 patches6 repliesSuperseded
v12 patches1 replySuperseded

Changes in v6 from the cover letter

- fixed bug in get/set pin
- added error checking that Cédric suggested

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500hw/gpio/Makefile.objs hw/gpio/aspeed_gpio.c include/hw/gpio/aspeed_gpio.h+983 -00 replies
2/3aspeed: add a GPIO controller to the SoChw/arm/aspeed_soc.c include/hw/arm/aspeed_soc.h+20 -00 replies
3/3hw/gpio: Add in AST2600 specific implementationhw/gpio/aspeed_gpio.c+137 -50 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchCédric Le GoaterAndrew Jeffery
1/3R-b T-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Qemu-arm] [PATCH v6 0/3] Add Aspeed GPIO controller model

v6:
- fixed bug in get/set pin
- added error checking that Cédric suggested

v5:
- integrated AspeedGPIOController fields into AspeedGPIOClass
- separated ast2600_3_6v and ast2600_1_8v into two classes

v4:
- proper interupt handling thanks to Andrew
- switch statements for reading and writing suggested by Peter
- some small cleanups suggested by Alexey

v3:
- didn't have each gpio set up as an irq
- now can't access set AC on ast2400 (only exists on ast2500)
- added ast2600 implementation (patch 3)
- renamed a couple of variables for clarity

v2: Addressed Andrew's feedback, added debounce regs, renamed get/set to read/write to minimise confusion with a 'set' of registers.

Rashmica Gupta (3):
hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500
aspeed: add a GPIO controller to the SoC
hw/gpio: Add in AST2600 specific implementation

 include/hw/arm/aspeed_soc.h   |    3 +
 include/hw/gpio/aspeed_gpio.h |  100 ++++
 hw/arm/aspeed_soc.c           |   17 +
 hw/gpio/aspeed_gpio.c         | 1014 +++++++++++++++++++++++++++++++++
 hw/gpio/Makefile.objs         |    1 +
 5 files changed, 1135 insertions(+)
 create mode 100644 include/hw/gpio/aspeed_gpio.h
 create mode 100644 hw/gpio/aspeed_gpio.c
Signature · 1 line
2.20.1