Skip to content

Enable iotests during "make check"

Thomas Huth qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 16 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Added dependency for "check-block" so that the *-softmmu targets are now built first
- Added 197 and 215 back to gitlab-ci.yml (there is no problem if they do not run in parallel with the qtests)
- Removed 122 from the "auto" group (does not work on ZFS according to Alex)
- Removed 181 and 201 from the "auto" group (they do not work if the default machine of QEMU does not support migration)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tests/qemu-iotests/check: Allow tests without groupstests/qemu-iotests/check+2 -20 replies
2/4tests/qemu-iotests/group: Remove some more tests from the "auto" grouptests/qemu-iotests/group+61 -590 replies
3/4tests: Run the iotests during "make check" againtests/Makefile.include tests/check-block.sh tests/qemu-iotests-quick.sh+40 -220 replies
4/4gitlab-ci: Remove qcow2 tests that are handled by "make check" already.gitlab-ci.yml+4 -90 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchAlex BennéeMax Reitz
1/4R-b R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] Enable iotests during "make check"

Let's enable the block iotests during "make check" again, to avoid that they get broken so easily by accident (like we've seen many times in the past).

v3:
- Added dependency for "check-block" so that the *-softmmu targets are now built first
- Added 197 and 215 back to gitlab-ci.yml (there is no problem if they do not run in parallel with the qtests)
- Removed 122 from the "auto" group (does not work on ZFS according to Alex)
- Removed 181 and 201 from the "auto" group (they do not work if the default machine of QEMU does not support migration)

v2:
- Added new patch to allow tests without groups, removed the "o_direct" group again.
- Removed some more tests from the "auto" group, like 197 and 215 which were sometimes causing the CI pipelines to fail on gitlab
- Added a patch to remove the "duplicated" tests from the gitlab-ci.yml file.

Thomas Huth (4):
tests/qemu-iotests/check: Allow tests without groups tests/qemu-iotests/group: Remove some more tests from the "auto" group
tests: Run the iotests during "make check" again
gitlab-ci: Remove qcow2 tests that are handled by "make check" already

 .gitlab-ci.yml              |  13 ++--
 tests/Makefile.include      |  10 +--
 tests/check-block.sh        |  44 ++++++++++---
 tests/qemu-iotests-quick.sh |   8 ---
 tests/qemu-iotests/check    |   4 +-
 tests/qemu-iotests/group    | 120 ++++++++++++++++++------------------
 6 files changed, 107 insertions(+), 92 deletions(-)
 delete mode 100755 tests/qemu-iotests-quick.sh
Signature · 1 line
2.21.0