Skip to content

panic/printk/x86: Prevent some more printk-related deadlocks in panic()

Petr Mladek lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2printk/panic: Access the main printk log in panic() only when safeinclude/linux/printk.h kernel/panic.c kernel/printk/printk_safe.c+58 -329 replies
2/2printk/panic/x86: Allow to access printk log buffer after crash_smp_send_stop()arch/x86/kernel/crash.c include/linux/printk.h kernel/panic.c +1 more+13 -74 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKonstantin Khebnikov
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] panic/printk/x86: Prevent some more printk-related deadlocks in panic()

Hi,

I have found some spare duct tape and wrapped some more printk-related deadlocks in panic().

More seriously, someone reported a deadlock in panic(). Some non-trivial debugging pointed out a problem with the following combination:

+ x86_64 architecture
+ panic()
+ pstore configured as message dumper (kmsg_dump())
+ crash kernel configured
+ crash_kexec_post_notifiers

In this case, CPUs are stopped by crash_smp_send_stop(). It uses NMI but it does not modify cpu_online_mask. Therefore logbuf_lock might stay locked, see 2nd patch for more details.

The above is a real corner case. But similar problem seems to be even in the common situations on architectures that do not use NMI in smp_send_stop() as a fallback, see 1st patch.

Back to the duct tape. I hope that we will get rid of these problems with the lockless printk ringbuffer rather sooner than later. But it still might take some time. And the two fixes might be useful also for stable kernels.

Petr Mladek (2):
printk/panic: Access the main printk log in panic() only when safe printk/panic/x86: Allow to access printk log buffer after
crash_smp_send_stop()

 arch/x86/kernel/crash.c     |  6 +++++-
 include/linux/printk.h      |  6 ++++++
 kernel/panic.c              | 49 +++++++++++++++++++++++++++------------------
 kernel/printk/printk_safe.c | 37 ++++++++++++++++++++++------------
 4 files changed, 65 insertions(+), 33 deletions(-)
Signature · 1 line
2.16.4