virtio-balloon: fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 5 repliesIn review
- v36 patches 4 repliesSuperseded
- v23 patches 8 repliesSuperseded
Changes in v4 from the cover letter
- Add "virtio-balloon: No need to track subpages for the PBP anymore", which doesn't need a stable backport
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | virtio-balloon: Fix wrong sign extension of PFNshw/ | +1 | 1 reply | |
| 2/7 | virtio-balloon: Fix QEMU crashes on pagesize > BALLOON_PAGE_SIZEhw/ | +4 | 0 replies | |
| 3/7 | virtio-balloon: Simplify deflate with pbphw/ | +5 | 0 replies | |
| 4/7 | virtio-balloon: Better names for offset variables in inflate/deflate codehw/ | +13 | 0 replies | |
| 5/7 | virtio-balloon: Rework pbp tracking datahw/ | +46 | 1 reply | |
| 6/7 | virtio-balloon: Use temporary PBP onlyhw/ include/ | +9 | 2 replies | |
| 7/7 | virtio-balloon: No need to track subpages for the PBP anymorehw/ | +3 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | David Gibson | Pankaj Gupta |
|---|---|---|
| 1/7 | R-b | R-b |
| 2/7 | A-b | |
| 3/7 | A-b | |
| 4/7 | A-b | |
| 5/7 | R-b | |
| 6/7 | A-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH-for-4.1 v4 0/7] virtio-balloon: fixes
As we discovered yet another issue with current PBP code, we decided to use a temporary PBP only, limited to one series of inflation requests.
Patch #1 is a fix for a wrong sign extension (MST brought this up but wasn't sure if it is broken - I think it is indeed broken). Patch #2 fixed QEMU segfaults. Patch #3 and #4 are cleanups that make follow-up fixes easier. Patch #5 avoids using RAMBlock addresses as tokens and patch #6 fixes all kinds of issues related to using a global PBP. Patch #7 gets rid of a temporary workaround from patch #5.
We want to have patches 1-6 in 4.1 and backport them to 4.0. Patch #1 needs backports to basically all QEMU releases with virtio-balloon.
Did a quick sanity test, hopefully no other BUG sneeked in. Will do some more testing.
v3 -> v4:
- Add "virtio-balloon: No need to track subpages for the PBP anymore", which doesn't need a stable backport
David Hildenbrand (7):
virtio-balloon: Fix wrong sign extension of PFNs
virtio-balloon: Fix QEMU crashes on pagesize > BALLOON_PAGE_SIZE
virtio-balloon: Simplify deflate with pbp
virtio-balloon: Better names for offset variables in inflate/deflate
code
virtio-balloon: Rework pbp tracking data
virtio-balloon: Use temporary PBP only
virtio-balloon: No need to track subpages for the PBP anymore
hw/virtio/virtio-balloon.c | 120 ++++++++++++++--------------- include/hw/virtio/virtio-balloon.h | 3 - 2 files changed, 60 insertions(+), 63 deletions(-)
Signature · 1 line
2.21.0