flow_offload fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest4 patches 1 replyIn review
- v44 patches 4 repliesSuperseded
- v34 patches 1 replySuperseded
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | net: openvswitch: rename flow_stats to sw_flow_statsnet/ net/ net/ | +10 | 0 replies | |
| 2/4 | net: flow_offload: remove netns parameter from flow_block_cb_alloc()drivers/ drivers/ drivers/ +5 more | +12 | 0 replies | |
| 3/4 | net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_tdrivers/ drivers/ include/ +9 more | +30 | 0 replies | |
| 4/4 | net: flow_offload: add flow_block structure and use itdrivers/ drivers/ drivers/ +10 more | +44 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Pirko |
|---|---|
| 1/4 | A-b |
| 2/4 | A-b |
| 3/4 | A-b |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH nf,v5 0/4] flow_offload fixes
Hi,
The following patchset contains fixes for the flow_offload infrastructure:
1) Fix possible build breakage before patch 3/4. Both the flow_offload infrastructure and OVS define the flow_stats structure. Patch 3/4 in this batch indirectly pulls in the flow_stats definition from include/net/flow_offload.h into OVS, leading to structure redefinition compile-time errors.
2) Remove netns parameter from flow_block_cb_alloc(), this is not required as Jiri suggests. The flow_block_cb_is_busy() function uses the per-driver block list to check for used blocks which was the original intention for this parameter.
3) Rename tc_setup_cb_t to flow_setup_cb_t. This callback is not exclusive of tc anymore, this might confuse the reader as Jiri suggests, fix this semantic inconsistency.
Add #include <linux/list.h> to include/net/netfilter/nf_tables_offload.h to avoid a compile break with CONFIG_HEADER_TEST=y.
4) Fix block sharing feature: Add flow_block structure and use it, update flow_block_cb_lookup() to use this flow_block object.
Please, apply, thank you.
Pablo Neira Ayuso (4):
net: openvswitch: rename flow_stats to sw_flow_stats
net: flow_offload: remove netns parameter from flow_block_cb_alloc()
net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t
net: flow_offload: add flow_block structure and use it
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 5 ++-- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 15 ++++++----- drivers/net/ethernet/mscc/ocelot_flower.c | 11 ++++---- drivers/net/ethernet/mscc/ocelot_tc.c | 6 ++--- .../net/ethernet/netronome/nfp/flower/offload.c | 11 ++++---- include/net/flow_offload.h | 30 ++++++++++++++++------ include/net/netfilter/nf_tables.h | 5 ++-- include/net/pkt_cls.h | 5 ++-- include/net/sch_generic.h | 8 +++--- net/core/flow_offload.c | 22 ++++++++-------- net/dsa/slave.c | 6 ++--- net/netfilter/nf_tables_api.c | 2 +- net/netfilter/nf_tables_offload.c | 5 ++-- net/openvswitch/flow.c | 8 +++--- net/openvswitch/flow.h | 4 +-- net/openvswitch/flow_table.c | 8 +++--- net/sched/cls_api.c | 12 ++++++--- net/sched/cls_bpf.c | 2 +- net/sched/cls_flower.c | 2 +- net/sched/cls_matchall.c | 2 +- net/sched/cls_u32.c | 6 ++--- 21 files changed, 94 insertions(+), 81 deletions(-)
Signature · 1 line
2.11.0