Skip to content

DP MST Refactors + debugging tools + suspend/resume reprobing

Lyude Paul amd-gfx dri-devel intel-gfx lkml nouveau 2 versions – Applied

Status from this message: Applied. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest27 patches 32 repliesApplied
  2. v126 patches 18 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/27drm/dp_mst: Move link address dumping into a functiondrivers/gpu/drm/drm_dp_mst_topology.c+23 -121 reply
2/27drm/dp_mst: Get rid of list clear in destroy_connector_workdrivers/gpu/drm/drm_dp_mst_topology.c+0 -21 reply
3/27drm/dp_mst: Destroy MSTBs asynchronouslydrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+127 -614 replies
4/27drm/dp_mst: Move test_calc_pbn_mode() into an actual selftestdrivers/gpu/drm/drm_dp_mst_topology.c drivers/gpu/drm/selftests/Makefile drivers/gpu/drm/selftests/drm_modeset_selftests.h +2 more+37 -281 reply
5/27drm/print: Add drm_err_printer()drivers/gpu/drm/drm_print.c include/drm/drm_print.h+23 -00 replies
6/27drm/dp_mst: Combine redundant cases in drm_dp_encode_sideband_req()drivers/gpu/drm/drm_dp_mst_topology.c+2 -62 replies
7/27drm/dp_mst: Add sideband down request tracing + selftestsdrivers/gpu/drm/drm_dp_mst_topology.c drivers/gpu/drm/drm_dp_mst_topology_internal.h drivers/gpu/drm/selftests/drm_modeset_selftests.h +3 more+536 -51 reply
8/27drm/dp_mst: Remove PDT teardown in drm_dp_destroy_port() and refactordrivers/gpu/drm/drm_dp_mst_topology.c+16 -241 reply
9/27drm/dp_mst: Refactor drm_dp_send_enum_path_resourcesdrivers/gpu/drm/drm_dp_mst_topology.c+16 -80 replies
10/27drm/dp_mst: Remove huge conditional in drm_dp_mst_handle_up_req()drivers/gpu/drm/drm_dp_mst_topology.c+45 -450 replies
11/27drm/dp_mst: Constify guid in drm_dp_get_mst_branch_by_guid()drivers/gpu/drm/drm_dp_mst_topology.c+2 -21 reply
12/27drm/dp_mst: Refactor drm_dp_mst_handle_up_req()drivers/gpu/drm/drm_dp_mst_topology.c+38 -370 replies
13/27drm/dp_mst: Refactor drm_dp_mst_handle_down_rep()drivers/gpu/drm/drm_dp_mst_topology.c+50 -520 replies
14/27drm/dp_mst: Destroy topology_mgr mutexesdrivers/gpu/drm/drm_dp_mst_topology.c+5 -01 reply
15/27drm/dp_mst: Cleanup drm_dp_send_link_address() a bitdrivers/gpu/drm/drm_dp_mst_topology.c+23 -191 reply
16/27drm/dp_mst: Refactor pdt setup/teardown, add more lockingdrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+110 -773 replies
17/27drm/dp_mst: Rename drm_dp_add_port and drm_dp_update_portdrivers/gpu/drm/drm_dp_mst_topology.c+10 -71 reply
18/27drm/dp_mst: Remove lies in {up,down}_rep_recv documentationinclude/drm/drm_dp_mst_helper.h+2 -61 reply
19/27drm/dp_mst: Handle UP requests asynchronouslydrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+122 -401 reply
20/27drm/dp_mst: Protect drm_dp_mst_port members with connection_mutexdrivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+133 -502 replies
21/27drm/dp_mst: Don't forget to update port->input in drm_dp_mst_handle_conn_stat()drivers/gpu/drm/drm_dp_mst_topology.c+37 -141 reply
22/27drm/nouveau: Don't grab runtime PM refs for HPD IRQsdrivers/gpu/drm/nouveau/nouveau_connector.c+17 -161 reply
23/27drm/amdgpu: Iterate through DRM connectors correctlydrivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +8 more+195 -732 replies
24/27drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topologydrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+3 -34 replies
25/27drm/dp_mst: Add basic topology reprobing when resumingdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/drm_dp_mst_topology.c drivers/gpu/drm/i915/display/intel_dp.c +2 more+112 -402 replies
26/27drm/dp_mst: Also print unhashed pointers for malloc/topology referencesdrivers/gpu/drm/drm_dp_mst_topology.c+20 -142 replies
27/27drm/dp_mst: Add topology ref history tracking for debuggingdrivers/gpu/drm/Kconfig drivers/gpu/drm/drm_dp_mst_topology.c include/drm/drm_dp_mst_helper.h+288 -41 reply

Reviews trailers per patch

24 of 27 patches have a Reviewed-by or Acked-by.

PatchDaniel VetterDave AirlieAlex DeucherSean Paul
1/27R-b R-b
2/27R-b R-b
3/27R-b
4/27R-b R-b
5/27R-b
6/27R-b R-b
7/27R-b
8/27R-b
9/27R-b
10/27
11/27R-b
12/27R-b
13/27R-b
14/27R-b
15/27R-b
16/27R-b
17/27R-b
18/27R-b
19/27R-b
20/27
21/27R-b
22/27R-b
23/27R-b
24/27A-b A-b
25/27R-b
26/27
27/27R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/27] DP MST Refactors + debugging tools + suspend/resume reprobing

This is the large series for adding MST suspend/resume reprobing that I've been working on for quite a while now. In addition, I:

- Refactored and cleaned up any code I ended up digging through in the process of understanding how some parts of these helpers worked.
- Added some debugging tools along the way that I ended up needing to figure out some issues in my own code

Note that there's still one important part of this process missing that's not included in this patch series: EDID reprobing, which I believe Stanislav Lisovskiy from Intel is currently working on. The main purpose of this series is to fix the issue of the in-memory topology state (e.g. connectors connected to an MST hub, branch devices, etc.) going out of sync if a topology connected to a connector is swapped out with a different topology while the system is resumed, or while the device housing said connector is in runtime suspend.

As well, the debugging tools that are added in this include:
- A limited debugging utility for dumping the list of topology references on an MST port or branch connector whose topology reference count has reached 0
- Sideband down request dumping, along with some basic selftests for testing our encoding/decoding functions

Patchseries wide changes since v1
- Add "Combine redundant cases in drm_dp_encode_sideband_req()" to fulfill some of the danvet's review requests

Lyude Paul (27):
drm/dp_mst: Move link address dumping into a function drm/dp_mst: Get rid of list clear in destroy_connector_work drm/dp_mst: Destroy MSTBs asynchronously
drm/dp_mst: Move test_calc_pbn_mode() into an actual selftest drm/print: Add drm_err_printer()
drm/dp_mst: Combine redundant cases in drm_dp_encode_sideband_req() drm/dp_mst: Add sideband down request tracing + selftests drm/dp_mst: Remove PDT teardown in drm_dp_destroy_port() and refactor drm/dp_mst: Refactor drm_dp_send_enum_path_resources drm/dp_mst: Remove huge conditional in drm_dp_mst_handle_up_req() drm/dp_mst: Constify guid in drm_dp_get_mst_branch_by_guid() drm/dp_mst: Refactor drm_dp_mst_handle_up_req() drm/dp_mst: Refactor drm_dp_mst_handle_down_rep() drm/dp_mst: Destroy topology_mgr mutexes
drm/dp_mst: Cleanup drm_dp_send_link_address() a bit drm/dp_mst: Refactor pdt setup/teardown, add more locking drm/dp_mst: Rename drm_dp_add_port and drm_dp_update_port drm/dp_mst: Remove lies in {up,down}_rep_recv documentation drm/dp_mst: Handle UP requests asynchronously
drm/dp_mst: Protect drm_dp_mst_port members with connection_mutex drm/dp_mst: Don't forget to update port->input in
drm_dp_mst_handle_conn_stat()
drm/nouveau: Don't grab runtime PM refs for HPD IRQs drm/amdgpu: Iterate through DRM connectors correctly drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology drm/dp_mst: Add basic topology reprobing when resuming drm/dp_mst: Also print unhashed pointers for malloc/topology
references
drm/dp_mst: Add topology ref history tracking for debugging

 drivers/gpu/drm/Kconfig                       |   14 +
 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    |   13 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   20 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   |    5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c  |   40 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c       |    5 +-
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        |   34 +-
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c        |   34 +-
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |   40 +-
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |   34 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   41 +-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c |   10 +-
 drivers/gpu/drm/drm_dp_mst_topology.c         | 1633 +++++++++++++----
 .../gpu/drm/drm_dp_mst_topology_internal.h    |   24 +
 drivers/gpu/drm/drm_print.c                   |    6 +
 drivers/gpu/drm/i915/display/intel_dp.c       |    3 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c       |    6 +-
 drivers/gpu/drm/nouveau/nouveau_connector.c   |   33 +-
 drivers/gpu/drm/selftests/Makefile            |    2 +-
 .../gpu/drm/selftests/drm_modeset_selftests.h |    2 +
 .../drm/selftests/test-drm_dp_mst_helper.c    |  238 +++
 .../drm/selftests/test-drm_modeset_common.h   |    2 +
 include/drm/drm_dp_mst_helper.h               |  143 +-
 include/drm/drm_print.h                       |   17 +
 24 files changed, 1873 insertions(+), 526 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_dp_mst_topology_internal.h
 create mode 100644 drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
Signature · 6 lines
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx