Skip to content

drm/via: drop use of deprecated headers drmP.h + drm_os_linux.h

Sam Ravnborg dri-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 3 repliesIn review
  2. v34 patches 0 repliesSuperseded
  3. v2 posting 2/24 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/20 of 6 patches0 repliesSuperseded
v16 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Use a more standard variant for via_write8_mask() (Emil)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/via: drop use of DRM(READ|WRITE) macrosdrivers/gpu/drm/via/via_dma.c drivers/gpu/drm/via/via_dmablit.c drivers/gpu/drm/via/via_drv.h +2 more+84 -640 replies
2/4drm/via: copy DRM_WAIT_ON as VIA_WAIT_ON and use itdrivers/gpu/drm/via/via_dmablit.c drivers/gpu/drm/via/via_drv.h drivers/gpu/drm/via/via_irq.c +1 more+46 -60 replies
3/4drm/via: make via_drv.h self-containeddrivers/gpu/drm/via/via_drv.h+3 -00 replies
4/4drm/via: drop use of drmP.hdrivers/gpu/drm/via/via_dma.c drivers/gpu/drm/via/via_dmablit.c drivers/gpu/drm/via/via_drv.c +5 more+42 -170 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEmil Velikov
SeriesR-b
1/4
2/4
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] drm/via: drop use of deprecated headers drmP.h + drm_os_linux.h

This is some janitorial updates to the via driver
that is required to get rid of deprecated headers
in the drm subsystem.

The first three patches prepare for the removal of drmP.h. The last patch remove use of drmP.h and replace with necessary include files to fix build.

Build tested with various configs and various architectures.

I had preferred that the via driver was replaced by the openchrome driver, but until we have it then we need to deal with the legacy via driver when removing old cruft in the drm subsystem.

v4:
- Use a more standard variant for via_write8_mask() (Emil)

v3:
- Use static inline functions for the read/write operations (Emil)
- Use dedicated *_mask_or() and *_mask_and() (Emil)
- Replace DRM_WAIT_ON in same path that introduces VIA_WAIT_ON (Emil)
- Collected r-b's
- Changelog adjustments
- Rebased on top of drm-misc-next

v2:
- Add a copy of DRM_WAIT_ON to the via driver, keeping the changes to this legacy driver to a minimum. This also gives much more confidence that the driver continues to work as there is no changes in logic. Therefore dropped "RFT".
- Added Cc: Michel Dänzer <[email protected]> to all patches, as Michael have commented on the series.

Sam

Sam Ravnborg (4):
drm/via: drop use of DRM(READ|WRITE) macros drm/via: copy DRM_WAIT_ON as VIA_WAIT_ON and use it drm/via: make via_drv.h self-contained drm/via: drop use of drmP.h

 drivers/gpu/drm/via/via_dma.c      | 43 +++++++++++++---------
 drivers/gpu/drm/via/via_dmablit.c  | 41 +++++++++++----------
 drivers/gpu/drm/via/via_drv.c      |  7 +++-
 drivers/gpu/drm/via/via_drv.h      | 75 +++++++++++++++++++++++++++++++++++---
 drivers/gpu/drm/via/via_irq.c      | 54 ++++++++++++++-------------
 drivers/gpu/drm/via/via_map.c      |  6 ++-
 drivers/gpu/drm/via/via_mm.c       |  7 +++-
 drivers/gpu/drm/via/via_verifier.c | 22 +++++------
 drivers/gpu/drm/via/via_video.c    |  5 ++-
 9 files changed, 174 insertions(+), 86 deletions(-)

_______________________________________________
openchrome-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/openchrome-devel