Skip to content

xfs: stable fixes for v4.19.y - circa ~ v4.19.58

Luis Chamberlain linux-xfs stable 1 version Applied

Status from this message: I've queued this series up, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/9xfs: fix pagecache truncation prior to reflinkfs/xfs/xfs_reflink.c+3 -20 replies
2/9xfs: flush removing page cache in xfs_reflink_remap_prepfs/xfs/xfs_bmap_util.c fs/xfs/xfs_bmap_util.h fs/xfs/xfs_reflink.c+16 -50 replies
3/9xfs: don't overflow xattr listent bufferfs/xfs/xfs_attr_list.c fs/xfs/xfs_xattr.c+4 -00 replies
4/9xfs: rename m_inotbt_nores to m_finobt_noresfs/xfs/libxfs/xfs_ag_resv.c fs/xfs/libxfs/xfs_ialloc_btree.c fs/xfs/xfs_inode.c +1 more+5 -50 replies
5/9xfs: don't ever put nlink > 0 inodes on the unlinked listfs/xfs/xfs_inode.c fs/xfs/xfs_iops.c+17 -120 replies
6/9xfs: reserve blocks for ifree transaction during log recoveryfs/xfs/xfs_fsops.c fs/xfs/xfs_super.c+8 -00 replies
7/9xfs: fix reporting supported extra file attributes for statx()fs/xfs/xfs_iops.c+8 -00 replies
8/9xfs: serialize unaligned dio writes against all other dio writesfs/xfs/xfs_file.c+17 -100 replies
9/9xfs: abort unaligned nowait directio earlyfs/xfs/xfs_file.c+3 -30 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchDave ChinnerChristoph HellwigAmir GoldsteinDarrick J. WongBrian FosterAllison Henderson
1/9R-b R-b
2/9R-b R-b
3/9R-b R-b
4/9R-b R-b R-b
5/9R-b R-b
6/9R-b R-b R-b
7/9R-b
8/9R-b R-b R-b
9/9R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] xfs: stable fixes for v4.19.y - circa ~ v4.19.58

"Oyez Oyez..." its time for a stable update of fixes for XFS. 4 out of the 9 fixes here were recommended by Amir, and tested by both Amir and Sasha. I've found a few other fixes, and have tested all these changes with fstests against the following configurations in fstests sections as per oscheck [0] and found no regressions in comparsin to v4.19.58 and by running the full set of tests 3 times completely:

* xfs
* xfs_nocrc
* xfs_nocrc_512
* xfs_reflink
* xfs_reflink_1024
* xfs_logdev
* xfs_realtimedev

Known issues are listed on the expunges files, but its no different than the current baseline.

Worth noting is a now known generic/388 crash on xfs_nocrc, xfs_reflink, and what may be a new section we should consider to track:
"xfs_reflink_normapbt" with the following resulting filesystem:

# xfs_info /dev/loop5
meta-data=/dev/loop5             isize=512    agcount=4, agsize=1310720 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=1, rmapbt=0
         =                       reflink=1
data     =                       bsize=4096   blocks=5242880, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1
log      =internal log           bsize=4096   blocks=2560, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0

Do we want to create a baseline and track this configuration for stable as well?

There is a stable bug tracking this, kz#204223 [1], and a respective bug also present on upstream via kz#204049 [2] which Zorro reported. But, again, nothing changes from the baseline.

I'd appreciate further reviews from the patches.

I have some other fixes in mind as well, but I'd rather not delay this set and think this is a first good batch.

This also goes out as the first set of stable fixes using oscheck's new devops infrastructure built on ansible / vagrant / terraform [3]. For this release I've used vagrant with KVM, perhaps the next one I'll try terraform on whatever cloud solution someone is willing to let me use.

You can also find these changes on my 20190718-linux-xfs-4.19.y-v1 branch on kernel.org [4].

Lemme know if you see any issues or have any questions.

[0] https://gitlab.com/mcgrof/oscheck/blob/master/fstests-configs/xfs.config
[1] https://bugzilla.kernel.org/show_bug.cgi?id=204223
[2] https://bugzilla.kernel.org/show_bug.cgi?id=204049
[3] https://gitlab.com/mcgrof/kdevops
[4] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-stable.git/log/?h=20190718-linux-xfs-4.19.y-v1

Brian Foster (1):
xfs: serialize unaligned dio writes against all other dio writes

Darrick J. Wong (6):
xfs: fix pagecache truncation prior to reflink
xfs: don't overflow xattr listent buffer
xfs: rename m_inotbt_nores to m_finobt_nores
xfs: don't ever put nlink > 0 inodes on the unlinked list
xfs: reserve blocks for ifree transaction during log recovery
xfs: abort unaligned nowait directio early

Dave Chinner (1):
xfs: flush removing page cache in xfs_reflink_remap_prep

Luis R. Rodriguez (1):
xfs: fix reporting supported extra file attributes for statx()

 fs/xfs/libxfs/xfs_ag_resv.c      |  2 +-
 fs/xfs/libxfs/xfs_ialloc_btree.c |  4 ++--
 fs/xfs/xfs_attr_list.c           |  1 +
 fs/xfs/xfs_bmap_util.c           |  2 +-
 fs/xfs/xfs_bmap_util.h           |  2 ++
 fs/xfs/xfs_file.c                | 27 +++++++++++++++++----------
 fs/xfs/xfs_fsops.c               |  1 +
 fs/xfs/xfs_inode.c               | 18 +++++++-----------
 fs/xfs/xfs_iops.c                | 21 +++++++++++++++++++--
 fs/xfs/xfs_mount.h               |  2 +-
 fs/xfs/xfs_reflink.c             | 16 +++++++++++++---
 fs/xfs/xfs_super.c               |  7 +++++++
 fs/xfs/xfs_xattr.c               |  3 +++
 13 files changed, 75 insertions(+), 31 deletions(-)
Signature · 1 line
2.20.1