Skip to content

mm/hmm: fixes for device private page migration

Ralph Campbell linux-mm lkml stable 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 7 repliesIn review 1 of 3 applied
  2. v23 patches 12 repliesSuperseded 1 of 3 applied
  3. v13 patches 0 repliesSuperseded

Patches in v3 1 of 3 applied

#Subject and filesSizeRepliesApplied
1/3mm: document zone device struct page field usageinclude/linux/mm_types.h+10 -14 replies
2/3mm/hmm: fix ZONE_DEVICE anon page mapping reusekernel/memremap.c+24 -02 replies
3/3mm/hmm: Fix bad subpage pointer in try_to_unmap_onemm/rmap.c+8 -01 replyApplied

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJohn HubbardChristoph Hellwig
1/3R-b
2/3R-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] mm/hmm: fixes for device private page migration

Testing the latest linux git tree turned up a few bugs with page migration to and from ZONE_DEVICE private and anonymous pages. Hopefully this series clarifies how ZONE_DEVICE private struct page uses the same mapping and index fields from the source anonymous page mapping.

Changes from v2 to v3:

Patch #1 is basically new (like v1 but with comments from v2) to accommodate Matthew Wilcox's NAK of v2 and Christoph's objection to adding _zd_pad fields in v1.

Patch #2 adds reviewed-by

Patch #3 adds comments explaining the reason for setting "subpage".

Changes from v1 to v2:

Patch #1 merges ZONE_DEVICE page struct into a union of lru and a struct for ZONE_DEVICE fields. So, basically a new patch.

Patch #2 updates the code comments for clearing page->mapping as suggested by John Hubbard.

Patch #3 is unchanged from the previous posting but note that Andrew Morton has v1 queued in v5.2-mmotm-2019-07-18-16-08.

Ralph Campbell (3):
mm: document zone device struct page reserved fields mm/hmm: fix ZONE_DEVICE anon page mapping reuse mm/hmm: Fix bad subpage pointer in try_to_unmap_one

 include/linux/mm_types.h | 9 ++++++++-
 kernel/memremap.c        | 4 ++++
 mm/rmap.c                | 1 +
 3 files changed, 13 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1