Measure Tiny Code Generation Quality
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest11 patches 12 repliesIn review
- v710 patches 0 repliesSuperseded
- v610 patches 6 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 10 patches | 10 replies | Superseded | |
| v4 | 7 patches | 10 replies | Superseded |
Changes in v8 from the cover letter
- fixing missing commit from v7
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | accel: introducing TBStatistics structureaccel/ accel/ accel/ +5 more | +213 | 1 reply | |
| 2/11 | accel: collecting TB execution countaccel/ accel/ accel/ +6 more | +55 | 3 replies | |
| 3/11 | accel: collecting JIT statisticsaccel/ accel/ include/ +2 more | +58 | 1 reply | |
| 4/11 | accel: replacing part of CONFIG_PROFILER with TBStatsaccel/ accel/ include/ +2 more | +119 | 0 replies | |
| 5/11 | accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILERaccel/ accel/ configure +7 more | +156 | 1 reply | |
| 6/11 | Adding -d tb_stats to control TBStatistics collection:include/ include/ include/ +2 more | +82 | 1 reply | |
| 7/11 | monitor: adding tb_stats hmp commandaccel/ hmp-commands.hx include/ +3 more | +192 | 1 reply | |
| 8/11 | Adding tb_stats [start|pause|stop|filter] command to hmp.monitor/ | +2 | 1 reply | |
| 9/11 | Adding info [tb-list|tb|coverset] commands to HMP.accel/ accel/ disas.c +6 more | +634 | 1 reply | |
| 10/11 | monitor: adding new info cfg commandaccel/ hmp-commands-info.hx include/ +1 more | +194 | 1 reply | |
| 11/11 | linux-user: dumping hot TBs at the end of the executionlinux-user/ | +4 | 0 replies |
Reviews trailers per patch
6 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Alex Bennée | Dr. David Alan Gilbert |
|---|---|---|
| 1/11 | R-b | |
| 2/11 | ||
| 3/11 | R-b | |
| 4/11 | R-b | |
| 5/11 | ||
| 6/11 | ||
| 7/11 | A-b | |
| 8/11 | A-b | |
| 9/11 | A-b | |
| 10/11 | ||
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v8 00/11] Measure Tiny Code Generation Quality
This patch is part of Google Summer of Code (GSoC) 2019. More about the project can be found in:
https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality
The goal of this patch is to add infrastructure to collect execution and JIT statistics during the emulation with accel/TCG. The statistics are stored in TBStatistic structures (TBStats) with each TB having its respective TBStats.
We added -d tb_stats and HMP tb_stats commands to allow the control of this statistics collection. And info tb, tbs, and coverset commands were also added to allow dumping and exploring all this information while emulating.
Collecting these statistics and information is useful to understand qemu performance and to help to add the support for traces to QEMU.
v8:
- fixing missing commit from v7
v7:
- rebase
- adding license to new files
- applying comments from v6
v6:
- applying comments from V5.
- change info tbs to info tb-list
- fix crash when dumping tb's targets
- fix "liveness/code time" calculation
v5:
- full replacement of CONFIG_PROFILER
- several fixes
- adds "info cfg"
- adds TB's targets to dump
vandersonmr (11):
accel: introducing TBStatistics structure
accel: collecting TB execution count
accel: collecting JIT statistics
accel: replacing part of CONFIG_PROFILER with TBStats
accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER Adding -d tb_stats to control TBStatistics collection:
monitor: adding tb_stats hmp command
Adding tb_stats [start|pause|stop|filter] command to hmp. Adding info [tb-list|tb|coverset] commands to HMP.
monitor: adding new info cfg command
linux-user: dumping hot TBs at the end of the execution
accel/tcg/Makefile.objs | 2 +- accel/tcg/cpu-exec.c | 4 + accel/tcg/tb-stats.c | 894 ++++++++++++++++++++++++++++++++++ accel/tcg/tcg-runtime.c | 7 + accel/tcg/tcg-runtime.h | 2 + accel/tcg/translate-all.c | 132 +++-- accel/tcg/translator.c | 5 + configure | 3 - cpus.c | 14 +- disas.c | 31 +- hmp-commands-info.hx | 31 ++ hmp-commands.hx | 17 + include/exec/exec-all.h | 15 +- include/exec/gen-icount.h | 10 + include/exec/tb-context.h | 12 + include/exec/tb-hash.h | 7 + include/exec/tb-stats-flags.h | 43 ++ include/exec/tb-stats.h | 170 +++++++ include/qemu/log-for-trace.h | 4 + include/qemu/log.h | 3 + include/qemu/timer.h | 5 +- linux-user/exit.c | 4 + monitor/misc.c | 171 ++++++- tcg/tcg.c | 230 +++------ tcg/tcg.h | 22 +- util/log.c | 90 +++- vl.c | 8 +- 27 files changed, 1652 insertions(+), 284 deletions(-) create mode 100644 accel/tcg/tb-stats.c create mode 100644 include/exec/tb-stats-flags.h create mode 100644 include/exec/tb-stats.h
Signature · 1 line
2.22.0