Skip to content

fix crash bug during rule restore

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3src: erec: fall back to internal location if its nullsrc/erec.c+3 -03 replies
2/3src: evaluate: don't rely on global chain ctx for error reportingsrc/evaluate.c+7 -70 replies
3/3src: evaluate: return immediately if no op was requestedsrc/evaluate.c tests/shell/testcases/cache/0003_cache_update_0+15 -07 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nft 0/3] fix crash bug during rule restore

https://bugzilla.netfilter.org/show_bug.cgi?id=1351

nft -f <<EOF
flush ruleset

table inet filter {
}

table inet filter {
      chain test {
        counter
    }
}

EOF

segfaults during error reporting.
First patch makes error handling more robust.
Second patch passes the right handle -- with above ruleset this highlights "chain test" in the resulting error message.

Last patch skips rule cache updates for invalid op to restore the 0.9.0 behaviour.