Skip to content

Remove time reset notifications

Dr. David Alan Gilbert (git) qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v13 patches 3 repliesApplied

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mc146818rtc: Remove reset notifiershw/timer/mc146818rtc.c+0 -190 replies
2/4timer: Remove reset notifiersinclude/qemu/timer.h util/qemu-timer.c+1 -420 replies
3/4replay: Remove host_clock_lastreplay/replay-snapshot.c+2 -51 reply
4/4timer: last, remove last bits of lastinclude/qemu/timer.h util/qemu-timer.c+1 -340 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchPavel Dovgalyuk
1/4
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [for 4.2 PATCH v2 0/4] Remove time reset notifications

From: "Dr. David Alan Gilbert" <[email protected]>

Timers have a mechanism for detecting host clock jumps; this relied on noticing if the time had gone backwards or if it had gone forward more than 60s since we last read it. This had assumed that we regularly read the time, which isn't true any more - we might not read the host timer until the guest explicitly reads the guest RTC (e.g. hwclock). This falsely triggers the reset mechanism.

The reset mechanism was only used by the mc146818 (i.e. PC) RTC anyway; so lets remove it.

v2
Remove the host_clock_last field in replay as per Pavel's review

Dr. David Alan Gilbert (4):
mc146818rtc: Remove reset notifiers
timer: Remove reset notifiers
replay: Remove host_clock_last
timer: last, remove last bits of last

 hw/timer/mc146818rtc.c   | 19 -------------------
 include/qemu/timer.h     | 35 ----------------------------------
 replay/replay-snapshot.c |  7 ++-----
 util/qemu-timer.c        | 41 +---------------------------------------
 4 files changed, 3 insertions(+), 99 deletions(-)
Signature · 1 line
2.21.0