Skip to content

ppc/pnv: add XIVE support for KVM guests

Cédric Le Goater qemu-devel 6 versions – Applied

Status from this message: Applied to ppc-for-5.0.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest20 patches 12 repliesApplied
  2. v523 patches 40 repliesApplied
  3. v425 patches 25 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v318 patches7 repliesApplied
v21 patch0 repliesSuperseded
v11 patch5 repliesSuperseded

Changes in v6 from the cover letter

- Included Greg's rework of the PowerNV chip core list
- Introduced a ppc_cpu_pir() helper
- Better pnv_xive_is_cpu_enabled() helper
- Extra fixes in pnv_xive_get_indirect_tctx()
- rework of the dump of the NVT table

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/20ppc/xive: Introduce a XivePresenter interfacehw/intc/xive.c include/hw/ppc/xive.h+49 -90 replies
2/20ppc/xive: Implement the XivePresenter interfacehw/intc/pnv_xive.c hw/intc/spapr_xive.c hw/intc/xive.c+97 -440 replies
3/20ppc/pnv: Instantiate cores separatelyhw/ppc/pnv.c include/hw/ppc/pnv.h+13 -190 replies
4/20ppc/pnv: Loop on the threads of the chip to find a matching NVThw/intc/pnv_xive.c+35 -261 reply
5/20ppc: Introduce a ppc_cpu_pir() helperhw/ppc/ppc.c include/hw/ppc/ppc.h+8 -20 replies
6/20ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helperhw/intc/pnv_xive.c include/hw/ppc/pnv.h+24 -01 reply
7/20ppc/pnv: Fix TIMA indirect accesshw/intc/pnv_xive.c hw/ppc/pnv.c include/hw/ppc/pnv.h+26 -61 reply
8/20ppc/xive: Introduce a XiveFabric interfacehw/intc/xive.c include/hw/ppc/xive.h+32 -00 replies
9/20ppc/pnv: Implement the XiveFabric interfacehw/ppc/pnv.c+35 -00 replies
10/20ppc/spapr: Implement the XiveFabric interfacehw/ppc/spapr.c+39 -00 replies
11/20ppc/xive: Use the XiveFabric and XivePresenter interfaceshw/intc/xive.c+17 -311 reply
12/20ppc/xive: Extend the TIMA operation with a XivePresenter parameterhw/intc/pnv_xive.c hw/intc/xive.c include/hw/ppc/xive.h+38 -311 reply
13/20ppc/pnv: Clarify how the TIMA is accessed on a multichip systemhw/intc/pnv_xive.c hw/ppc/pnv.c include/hw/ppc/pnv.h+40 -173 replies
14/20ppc/xive: Move the TIMA operations to the controller modelhw/intc/pnv_xive.c hw/intc/spapr_xive.c hw/intc/xive.c +1 more+65 -330 replies
15/20ppc/xive: Remove the get_tctx() XiveRouter handlerhw/intc/pnv_xive.c hw/intc/spapr_xive.c hw/intc/xive.c +1 more+0 -301 reply
16/20ppc/xive: Introduce a xive_tctx_ipb_update() helperhw/intc/xive.c include/hw/ppc/xive.h+12 -102 replies
17/20ppc/xive: Synthesize interrupt from the saved IPB in the NVThw/intc/xive.c+52 -00 replies
18/20ppc/pnv: Introduce a pnv_xive_block_id() helperhw/intc/pnv_xive.c include/hw/ppc/pnv_xive.h+33 -340 replies
19/20ppc/pnv: Extend XiveRouter with a get_block_id() handlerhw/intc/pnv_xive.c hw/intc/spapr_xive.c hw/intc/xive.c +1 more+29 -60 replies
20/20ppc/pnv: Dump the XIVE NVT tablehw/intc/pnv_xive.c include/hw/ppc/xive_regs.h+67 -00 replies

Reviews trailers per patch

11 of 20 patches have a Reviewed-by or Acked-by.

PatchGreg Kurz
1/20R-b
2/20R-b
3/20
4/20R-b
5/20
6/20
7/20
8/20R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20
14/20R-b
15/20R-b
16/20R-b
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/20] ppc/pnv: add XIVE support for KVM guests

Hello,

The QEMU PowerNV machine emulates a baremetal OpenPOWER system and acts as an hypervisor (L0). Supporting emulation of KVM to run guests (L1) requires a few more extensions, among which guest support for the XIVE interrupt controller on POWER9 processor.

The following changes extend the XIVE models with the new XiveFabric and XivePresenter interfaces to provide support for XIVE escalations and interrupt resend. This mechanism is used by XIVE to notify the hypervisor that a vCPU is not dispatched on a HW thread. Tested on a QEMU PowerNV machine and a simple QEMU pseries guest doing network on a local bridge.

The XIVE interrupt controller offers a way to increase the XIVE resources per chip by configuring multiple XIVE blocks on a chip. This is not currently supported by the model. However, some configurations, such as OPAL/skiboot, use one block-per-chip configuration with some optimizations. One of them is to override the hardwired chip ID by the block id in the PowerBUS operations and for CAM line compares. This patchset improves the support for this setup. Tested with 4 chips.

A series from Suraj adding guest support in the Radix MMU model of the QEMU PowerNV machine is still required and will be send later. The whole patchset can be found under :

https://github.com/legoater/qemu/tree/powernv-4.2

Thanks,

C.

Changes since v5:

- Included Greg's rework of the PowerNV chip core list
- Introduced a ppc_cpu_pir() helper
- Better pnv_xive_is_cpu_enabled() helper
- Extra fixes in pnv_xive_get_indirect_tctx()
- rework of the dump of the NVT table

Changes since v4:

- rebased on QEMU 4.2-rc1
- better commit logs
- moved fixes at the beginning of the patchset
- reworked pnv_xive_match_nvt() handler to loop on the all threads of a PnvChip

Changes since v3:

- reworked the patches introducing the XiveFabric and XivePresenter interfaces
- moved the get_block_id() handler to the XiveRouter
- new small addons related to the format of the trigger data

Changes since v2:

- introduced the XiveFabric and XivePresenter interfaces
- removed the need of a XiveRouter pointer under XiveTCTX

Changes since v1:

- minor extra fixes
- split the escalation support in different patches
- kept the XiveRouter type for XiveTCTX back pointer (will address this in P10)
- removed pnv_xive_vst_size(). Really broken on indirect tables.
- improved the dump of the NVT table
- introduce pnv_xive_get_block_id()

Cédric Le Goater (19):
ppc/xive: Introduce a XivePresenter interface
ppc/xive: Implement the XivePresenter interface ppc/pnv: Loop on the threads of the chip to find a matching NVT
ppc: Introduce a ppc_cpu_pir() helper
ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helper ppc/pnv: Fix TIMA indirect access
ppc/xive: Introduce a XiveFabric interface
ppc/pnv: Implement the XiveFabric interface
ppc/spapr: Implement the XiveFabric interface
ppc/xive: Use the XiveFabric and XivePresenter interfaces ppc/xive: Extend the TIMA operation with a XivePresenter parameter ppc/pnv: Clarify how the TIMA is accessed on a multichip system ppc/xive: Move the TIMA operations to the controller model ppc/xive: Remove the get_tctx() XiveRouter handler ppc/xive: Introduce a xive_tctx_ipb_update() helper ppc/xive: Synthesize interrupt from the saved IPB in the NVT ppc/pnv: Introduce a pnv_xive_block_id() helper ppc/pnv: Extend XiveRouter with a get_block_id() handler ppc/pnv: Dump the XIVE NVT table

Greg Kurz (1):
ppc/pnv: Instantiate cores separately

 include/hw/ppc/pnv.h       |  12 +-
 include/hw/ppc/pnv_xive.h  |   3 -
 include/hw/ppc/ppc.h       |   1 +
 include/hw/ppc/xive.h      |  67 ++++++++-
 include/hw/ppc/xive_regs.h |   3 +
 hw/intc/pnv_xive.c         | 290 ++++++++++++++++++++++++++++--------
 hw/intc/spapr_xive.c       |  88 ++++++++++-
 hw/intc/xive.c             | 293 +++++++++++++++++++------------------
 hw/ppc/pnv.c               |  96 +++++++++---
 hw/ppc/ppc.c               |   9 +-
 hw/ppc/spapr.c             |  39 +++++
 11 files changed, 657 insertions(+), 244 deletions(-)
Signature · 1 line
2.21.0