Support i.MX8MM/N
Get series with b4
b4 am 20190722235555.0e8c8ac5@jawaVersions newest first
- v1 Latest0 of 52 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 52 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 00/52] Support i.MX8MM/N
Quoted 28 lines · On Thu, 18 Jul 2019 09:12:02 +0200 Lukasz Majewski <[email protected]> wrote:
Hi Peng,
Quoted 26 lines
Hi Lukasz, Stefano,
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Subject: Re: [U-Boot] [PATCH 00/52] Support i.MX8MM/N
[....]
Quoted 20 lines
Quoted 8 lines
Quoted 8 lines
The v5 of CCF has been posted ~2 weeks ago (with you on CC) with a high chance to be pulled by Stefano after the merge window opens.
When we accept the "legacy" clock approach we will stuck with it for a long time.
Quoted 6 lines
Quoted 2 lines
What approach is took by the Linux kernel? CCF or any other one?
I am not against CCF. I tried CCF and enabled on i.MX8MM in my last patchset. But I have to add lots of code based on your version, that introduces complexity for now.
You will have to add this complexity anyway after people start demanding new clocks for IPs which they need to enable.
Moreover, the CCF v5 was posted 2 weeks ago - wasn't it enough time for applying your patches from v4?
Quoted 8 lines
Quoted 6 lines
I have converted back to CCF for i.MX8MM/N. Pushed code to https://github.com/MrVan/u-boot/commits/imx8mmn-ccf
Since there are 65 patches in my patchset, I not post to maillist.
Please see whether you have some general comments or not.
I will try to provide some comments today. Thanks for the conversion.
Your patches from the github tree up to [1] seems to not touch the core clock code and extend only clk-* (gate, mux, etc.) files.
They are similar to what you have posted previously on top of v4.
Two remarks:
- Please extract those CCF related github patches, port them on top of master with Stefano's last PR pulled and send to U-Boot mailing list (for final review and testing).
- I think that you can extend the sandbox test code [2] for binded clocks [3] - for example to read a clk freq value from such clock. Also test if the logic for "hiding" them works.
[1] -
https://github.com/MrVan/u-boot/commit/1a9b13178be10d0c6c6834808c36877b5b2dc49f
[2] -
https://github.com/MrVan/u-boot/commit/a89ca577c8c26aa962664dfe1f8e9fec1dd83f65
[3] -
https://github.com/MrVan/u-boot/commit/a088106f1b90b7ef6b7128c2c17671cd4d376aa9
Quoted 460 lines
Quoted 3 lines
Then I'll post out to mail list. Hope it could catch this release cycle.
Let's be optimistic.
Quoted 448 lines
Thanks,
Peng.Quoted 444 lines
Quoted 13 lines
Quoted 13 lines
Quoted 4 lines
We might try to switch to CCF again in future,
I'm a bit skeptical about such statements. It never works like that
- after it is accepted it would become a "legacy code which we do need to preserve".Quoted 3 lines
but we hope
i.MX8MM/N support could land in upstream soon. It has been pending for months.Quoted 7 lines
Quoted 2 lines
Was the CCF the reason for the i.MX8 not being pulled for so long?
I am not saying so.
The first version to support i.MX8MM is in 2019-01-28. Then I switch to CCF and posted out new version in 2019-4-30.
Maybe the version posted in 2019-01-28 was just not ready for being pulled?
It happens that the community wants to avoid problems encountered earlier with other SoCs (like i.MX6, i.MX7), so the discussion takes time.
(The similar situation is with other projects too - how many release cycles it takes to add new SoC in Linux? Or new port to glibc?).
Quoted 2 lines
we have many 3rd parties want to use mainline U-Boot, not our vendor tree.
There must be a reason that they want the U-Boot mainline. IMHO the main reason for it is that people not only from a single company want to add the code, so they need to discuss (and get the agreement) to avoid stepping in each other's toes.
And the discussion/tests takes time ...
Quoted 2 lines
I hope
i.MX8MM/N could land in the coming merge window,This depends solely on the code quality I think.
Quoted 1 line
introducing more to CCF add risk.
Risk for not being accepted?
I do see however other risk - the i.MX8 will gain one-off clock support code instead of adopting the CCF just from the outset.
Quoted 73 lines
Thanks,
Peng.Quoted 69 lines
Quoted 69 lines
Regards,
Peng.Quoted 64 lines
Quoted 64 lines
Bai Ping (1):
imx8mq: Update the ddrc QoS setting for B1 chipJacky Bai (2):
driver: ddr: Refine the ddr init driver on imx8m
ddr: imx8m: Fix the ddr init hang on imx8mqPeng Fan (47):
linux: compat: guardPAGE_SIZE
dm: clk: ignore default settings when node not valid
pinctrl: imx: usedevfdt_get_addr_size_index
i2c: mxc: addCONFIG_CLKsupport
tools:imx8m_image: align spl bin image size
ddr: imx8m: fix ddr firmware location when enable SPL
OF tools: imx8mimage: fix HDMI/FIT parsing
imx8m: add image cfg for i.MX8MM lpddr4
imx: add IMX8MQ kconfig entry
imx: add IMX8MM kconfig entry
imx: imx8mm: add clock bindings header
imx: add i.MX8MM cpu type
imx: spl: addspl_board_boot_devicefor i.MX8MM
imx8m: update imx-regs for i.MX8MM
imx: addget_cpu_revsupport for i.MX8MM
imx8m: rename clock toclock_imx8mq
imx8m: restructureclock.h
imx8m: add clk support for i.MX8MM
imx8m: soc: probe clk before relocation
imx8m: add pin header for i.MX8MM
imx: add i.MX8MM PE property
imx8m: Fix MMU table issue for OPTEE memory
imx8m: set BYPASS ID SWAP to avoid AXI bus errors
imx8m: soc: enable SCTR clock before timer init
serial:Kconfig: makeMXC_UARTusable for MX7 and
IMX8M clk: imx: addKconfigentry for i.MX8MM
clk: imx: add i.MX8MM clk driver
imx: add i.MX8MM EVK board support
imx: add i.MX8MN kconfig entry
imx8mn: supportget_cpu_rev
imx8m: add clk support for i.MX8MN
imx8mn: set BYPASS ID SWAP to avoid AXI bus errors
imx: add i.MX8MN PE property
imx8mn: add pin header
imx: spl: usespl_board_boot_devicefor i.MX8MN
spl: pass args toboard_return_to_bootrom
imx: add rom api support
imx: cpu: restrictget_boot_device
imx8mn: addget_boot_device
power: pmic: addSPL_DM_PMIC
tools: imx8mimage: add ROM VERSION
pinctrl: imx8m: support i.MX8MN
tools:imx8m_image: support ddr4 firmware
clk: imx: add i.MX8MN clk support
imx8m: add i.MX8MN ddr4 image cfg file
imx: add dtsi for i.MX8MN
imx: add i.MX8MN DDR4 board supportYe Li (2):
imx8m: Configure trustzone region 0 for non-secure
access ddr: imx8m: Fix ddr4 driver build issue
arch/arm/dts/Makefile
|4
Quoted 3 lines
Quoted 3 lines
+- > > > arch/arm/dts/imx8mm-evk-u-boot.dtsi | > > > 92+
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/dts/imx8mm-evk.dts
|235
Quoted 3 lines
Quoted 3 lines
+++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/dts/imx8mm-pinfunc.h
|629
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
+++++++
Quoted 2 lines
arch/arm/dts/imx8mm.dtsi
|733
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
++++++++
Quoted 3 lines
arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi|
92 +arch/arm/dts/imx8mn-ddr4-evk.dts
|221
Quoted 3 lines
Quoted 3 lines
+++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/dts/imx8mn-pinfunc.h
|646
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
+++++++
Quoted 2 lines
arch/arm/dts/imx8mn.dtsi
|712
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
+++++++
Quoted 2 lines
arch/arm/include/asm/arch-imx/cpu.h|
7+
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/include/asm/arch-imx8m/clock.h|
494+---- > > > arch/arm/include/asm/arch-imx8m/clock_imx8mm.h > > > |465
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
+++++
Quoted 2 lines
arch/arm/include/asm/arch-imx8m/clock_imx8mq.h|
424+++++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/include/asm/arch-imx8m/imx-regs.h|
75+- > > > > > arch/arm/include/asm/arch-imx8m/imx8mm_pins.h > > > > > | 691 > > > > +++++++ > > > > > arch/arm/include/asm/arch-imx8m/imx8mn_pins.h | > > > > > 763 > > > > ++++++++ > > > > > arch/arm/include/asm/mach-imx/iomux-v3.h > > > > > | 4 + > > > > > arch/arm/include/asm/mach-imx/mxc_i2c.h > > > > > | 2 + > > > > > arch/arm/include/asm/mach-imx/sys_proto.h | > > > > > 42 + > > > > > arch/arm/mach-imx/Kconfig > > > > > | 4 + > > > > > arch/arm/mach-imx/Makefile > > > > > | 2 + > > > > > arch/arm/mach-imx/cpu.c > > > > > | 16 > > +- > > > > > arch/arm/mach-imx/imx8m/Kconfig > > > > > | 28 > > +- > > > > > arch/arm/mach-imx/imx8m/Makefile > > > > > | 4 > > +- > > > > > arch/arm/mach-imx/imx8m/clock_imx8mm.c > > > > > | 707 > > > > +++++++ > > > > > .../arm/mach-imx/imx8m/{clock.c => clock_imx8mq.c} |Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines
7 +-
arch/arm/mach-imx/imx8m/clock_slice.c
| 815++++++++
Quoted 2 lines
arch/arm/mach-imx/imx8m/imximage-8mm-lpddr4.cfg
|16 +
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-imx/imx8m/imximage-8mn-ddr4.cfg
|17 +
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-imx/imx8m/soc.c
|162
Quoted 3 lines
Quoted 3 lines
+- > > > arch/arm/mach-imx/spl.c > > > |8 +
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-imx/spl_imx_romapi.c
|292
Quoted 3 lines
Quoted 3 lines
+++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-rockchip/rk3288-board-tpl.c|
5+- > > > > > arch/arm/mach-rockchip/rk3368-board-tpl.c | > > > > > 5 +- > > > > > arch/arm/mach-rockchip/rk3399-board-spl.c | > > > > > 5 +- > > > > > arch/arm/mach-rockchip/rk3399-board-tpl.c | > > > > > 5 +- > > > > > board/freescale/imx8mm_evk/Kconfig | > > > > > 12 + > > > > > board/freescale/imx8mm_evk/MAINTAINERS > > > > > | 6 > > + > > > > > board/freescale/imx8mm_evk/Makefile > > > > > | 12 + > > > > > board/freescale/imx8mm_evk/imx8mm_evk.c > > > > > | 90 > > + > > > > > board/freescale/imx8mm_evk/lpddr4_timing.c |Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
1980 ++++++++++++++++++++
board/freescale/imx8mm_evk/spl.c|
216+++
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
board/freescale/imx8mn_evk/Kconfig |
14
+ board/freescale/imx8mn_evk/MAINTAINERS |
6+
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
board/freescale/imx8mn_evk/Makefile |
12
+board/freescale/imx8mn_evk/ddr4_timing.c|
1214 ++++++++++++board/freescale/imx8mn_evk/imx8mn_evk.cQuoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
|
Quoted 2 lines
85 +
board/freescale/imx8mn_evk/spl.c
| 91+
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
board/freescale/imx8mq_evk/lpddr4_timing.c|
16 +-common/spl/spl_bootrom.c
| 7+- > > > > > configs/imx8mm_evk_defconfig | > > > > > 51 + > > > > > configs/imx8mn_ddr4_evk_defconfig |Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
55
+drivers/clk/clk-uclass.c|
3 +drivers/clk/imx/Kconfig
| 14 +drivers/clk/imx/Makefile|
1
+drivers/clk/imx/clk-imx8mm.c|
121++
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/ddr/imx/imx8m/Kconfig|
6
+drivers/ddr/imx/imx8m/Makefile|
4+- > > > > > drivers/ddr/imx/imx8m/ddr4_init.c |Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
113 --
drivers/ddr/imx/imx8m/ddr_init.c|
168 ++drivers/ddr/imx/imx8m/ddrphy_utils.c| 4 +drivers/ddr/imx/imx8m/helper.c|
22 +-drivers/ddr/imx/imx8m/lpddr4_init.c|
188 --drivers/i2c/mxc_i2c.c| 24+- > > > > > drivers/pinctrl/nxp/pinctrl-imx.c |Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
4 +-
drivers/pinctrl/nxp/pinctrl-imx8m.c
| 1 +drivers/power/pmic/Kconfig|
12
+drivers/power/pmic/Makefile|
2+- > > > > > drivers/serial/Kconfig |Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
2 +-
include/configs/imx8mm_evk.h
| 200++
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
include/configs/imx8mn_evk.h|
198++
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
include/dt-bindings/clock/imx8mm-clock.h|
244 +++include/dt-bindings/clock/imx8mn-clock.h|
215 +++include/imximage.h|
1+
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
include/linux/compat.h|
2
+include/power/pmic.h|
2+- > > > > > include/spl.h | > > > > > 3 +- > > > > > tools/imx8m_image.sh | 15 +- > > > > > tools/imx8mimage.c | 31 +- > > 79 > > > > filesQuoted 60 lines
Quoted 60 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
changed, 13082 insertions(+), 814 deletions(-) create mode 100644
arch/arm/dts/imx8mm-evk-u-boot.dtsicreate mode 100644arch/arm/dts/imx8mm-evk.dtscreate mode 100644arch/arm/dts/imx8mm-pinfunc.hcreate mode 100644arch/arm/dts/imx8mm.dtsicreate mode 100644arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsicreate mode 100644arch/arm/dts/imx8mn-ddr4-evk.dtscreate mode 100644arch/arm/dts/imx8mn-pinfunc.hcreate mode 100644arch/arm/dts/imx8mn.dtsicreate mode 100644arch/arm/include/asm/arch-imx8m/clock_imx8mm.hcreate mode100644
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/include/asm/arch-imx8m/clock_imx8mq.hcreate mode100644
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/include/asm/arch-imx8m/imx8mm_pins.hcreate mode100644
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/include/asm/arch-imx8m/imx8mn_pins.hcreate mode100644
Quoted 9 lines
Quoted 9 lines
Quoted 3 lines
arch/arm/mach-imx/imx8m/clock_imx8mm.crenamearch/arm/mach-imx/imx8m/{clock.c=>clock_imx8mq.c} (99%) createmode
Quoted 2 lines
100644
arch/arm/mach-imx/imx8m/imximage-8mm-lpddr4.cfgcreatemode
Quoted 2 lines
100644
arch/arm/mach-imx/imx8m/imximage-8mn-ddr4.cfgcreatemode
Quoted 29 lines
Quoted 29 lines
Quoted 25 lines
100644
arch/arm/mach-imx/spl_imx_romapi.ccreate mode 100644 board/freescale/imx8mm_evk/Kconfig create mode 100644 board/freescale/imx8mm_evk/MAINTAINERS create mode 100644 board/freescale/imx8mm_evk/Makefile create mode 100644board/freescale/imx8mm_evk/imx8mm_evk.ccreate mode 100644board/freescale/imx8mm_evk/lpddr4_timing.ccreate mode 100644board/freescale/imx8mm_evk/spl.ccreate mode 100644 board/freescale/imx8mn_evk/Kconfig create mode 100644 board/freescale/imx8mn_evk/MAINTAINERS create mode 100644 board/freescale/imx8mn_evk/Makefile create mode 100644board/freescale/imx8mn_evk/ddr4_timing.ccreate mode 100644board/freescale/imx8mn_evk/imx8mn_evk.ccreate mode 100644board/freescale/imx8mn_evk/spl.ccreate mode 100644 configs/imx8mm_evk_defconfig create mode 100644 configs/imx8mn_ddr4_evk_defconfig create mode 100644drivers/clk/imx/clk-imx8mm.cdelete mode 100644drivers/ddr/imx/imx8m/ddr4_init.ccreate mode 100644drivers/ddr/imx/imx8m/ddr_init.cdelete mode 100644drivers/ddr/imx/imx8m/lpddr4_init.ccreate mode 100644include/configs/imx8mm_evk.hcreate mode 100644include/configs/imx8mn_evk.hcreate mode 100644include/dt-bindings/clock/imx8mm-clock.hcreate mode 100644include/dt-bindings/clock/imx8mn-clock.hQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing
Director:Wolfgang
Quoted 9 lines
Quoted 9 lines
Quoted 3 lines
Quoted 3 lines
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax:
(+49)-8142-66989-80 Email: lukma at denx.deBest regards,
Quoted 8 lines
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director:
Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax:
(+49)-8142-66989-80 Email: lukma at denx.deBest regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang
Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.deBest regards,
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190722/44dea324/attachment.sig>