Skip to content

Introduce a BPF helper to generate SYN cookies

Petar Penkov bpf netdev 2 versions – Applied

Status from this message: Applied. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied
  2. v16 patches 6 repliesSuperseded

Changes in v2 from the cover letter

1/ Added performance numbers to the cover letter
2/ Patch 2: Refactored a bit to fix compilation issues 3/ Patch 3: Changed ENOTSUPP to EOPNOTSUPP at Toke's suggestion

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6tcp: tcp_syn_flood_action read port from socketnet/ipv4/tcp_input.c+3 -50 replies
2/6tcp: add skb-less helpers to retrieve SYN cookieinclude/net/tcp.h net/ipv4/tcp_input.c net/ipv4/tcp_ipv4.c +1 more+113 -00 replies
3/6bpf: add bpf_tcp_gen_syncookie helperinclude/uapi/linux/bpf.h net/core/filter.c+102 -10 replies
4/6bpf: sync bpf.h to tools/tools/include/uapi/linux/bpf.h+34 -30 replies
5/6selftests/bpf: bpf_tcp_gen_syncookie->bpf_helperstools/testing/selftests/bpf/bpf_helpers.h+3 -00 replies
6/6selftests/bpf: add test for bpf_tcp_gen_syncookietools/testing/selftests/bpf/progs/test_tcp_check_syncookie_kern.c tools/testing/selftests/bpf/test_tcp_check_syncookie.sh tools/testing/selftests/bpf/test_tcp_check_syncookie_user.c+99 -130 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchLorenz Bauer
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [bpf-next,v2 0/6] Introduce a BPF helper to generate SYN cookies

From: Petar Penkov <[email protected]>

This patch series introduces a BPF helper function that allows generating SYN cookies from BPF. Currently, this helper is enabled at both the TC hook and the XDP hook.

The first two patches in the series add/modify several TCP helper functions to allow for SKB-less operation, as is the case at the XDP hook.

The third patch introduces the bpf_tcp_gen_syncookie helper function which generates a SYN cookie for either XDP or TC programs. The return value of this function contains both the MSS value, encoded in the cookie, and the cookie itself.

The last three patches sync tools/ and add a test.

Performance evaluation:
I sent 10Mpps to a fixed port on a host with 2 10G bonded Mellanox 4 NICs from random IPv6 source addresses. Without XDP I observed 7.2Mpps (syn-acks) being sent out if the IPv6 packets carry 20 bytes of TCP options or 7.6Mpps if they carry no options. If I attached a simple program that checks if a packet is IPv6/TCP/SYN, looks up the socket, issues a cookie, and sends it back out after swapping src/dest, recomputing the checksum, and setting the ACK flag, I observed 10Mpps being sent back out.

Changes since v1:
1/ Added performance numbers to the cover letter
2/ Patch 2: Refactored a bit to fix compilation issues 3/ Patch 3: Changed ENOTSUPP to EOPNOTSUPP at Toke's suggestion

Changes since RFC:
1/ Cookie is returned in host order at Alexei's suggestion
2/ If cookies are not enabled via a sysctl, the helper function returns
-ENOENT instead of -EINVAL at Lorenz's suggestion
3/ Fixed documentation to properly reflect that MSS is 16 bits at
Lorenz's suggestion
4/ BPF helper requires TCP length to match ->doff field, rather than to simply
be no more than 20 bytes at Eric and Alexei's suggestion
5/ Packet type is looked up from the packet version field, rather than from the
socket. v4 packets are rejected on v6-only sockets but should work with dual stack listeners at Eric's suggestion
6/ Removed unnecessary net argument from helper function in patch 2 at
Lorenz's suggestion
7/ Changed test to only pass MSS option so we can convince the verifier that the
memory access is not out of bounds

Note that 7/ below illustrates the verifier might need to be extended to allow passing a variable tcph->doff to the helper function like below:

__u32 thlen = tcph->doff * 4;
if (thlen < sizeof(*tcph))

	return;

__s64 cookie = bpf_tcp_gen_syncookie(sk, ipv4h, 20, tcph, thlen);

Petar Penkov (6):
tcp: tcp_syn_flood_action read port from socket
tcp: add skb-less helpers to retrieve SYN cookie
bpf: add bpf_tcp_gen_syncookie helper
bpf: sync bpf.h to tools/
selftests/bpf: bpf_tcp_gen_syncookie->bpf_helpers selftests/bpf: add test for bpf_tcp_gen_syncookie

 include/net/tcp.h                             | 10 +++
 include/uapi/linux/bpf.h                      | 30 ++++++-
 net/core/filter.c                             | 73 +++++++++++++++++
 net/ipv4/tcp_input.c                          | 81 +++++++++++++++++--
 net/ipv4/tcp_ipv4.c                           | 15 ++++
 net/ipv6/tcp_ipv6.c                           | 15 ++++
 tools/include/uapi/linux/bpf.h                | 37 ++++++++-
 tools/testing/selftests/bpf/bpf_helpers.h     |  3 +
 .../bpf/progs/test_tcp_check_syncookie_kern.c | 48 +++++++++--
 .../selftests/bpf/test_tcp_check_syncookie.sh |  3 +
 .../bpf/test_tcp_check_syncookie_user.c       | 61 ++++++++++++--
 11 files changed, 354 insertions(+), 22 deletions(-)
Signature · 1 line
2.22.0.709.g102302147b-goog