Skip to content

kernel-shark: Be more careful with kshark-su-record

Steven Rostedt linux-trace-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kernel-shark: Execute kshark-record from same dir as kshark-su-recordkernel-shark/bin/kshark-su-record+2 -14 replies
2/2kernel-shark: Set the DISPLAY environment for pkexec kshark-recordkernel-shark/bin/kshark-su-record+1 -11 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchYordan Karadzhov (VMware)
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] kernel-shark: Be more careful with kshark-su-record

Two issues with kshark-su-record.

1) It just calls kshark-record with no path, which can be an issue if pkexec removes PATH variable, or sets it to something that kshark-record is not in.

2) Need to set DISPLAY variable, because on some of my machines, the kshark-record failed to execute due to pkexec removing the DISPLAY variable.

Steven Rostedt (VMware) (2):
kernel-shark: Execute kshark-record from same dir as kshark-su-record
kernel-shark: Set the DISPLAY environment for pkexec kshark-record

----

 kernel-shark/bin/kshark-su-record | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)