Skip to content

xfs: stable fixes for v4.19.y - circa v4.19.60

Luis Chamberlain linux-xfs stable 1 version Applied

Status from this message: I've queued them up for 4.19, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6xfs: don't trip over uninitialized buffer on extent read of corrupted inodefs/xfs/libxfs/xfs_bmap.c+4 -10 replies
2/6xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.hfs/xfs/libxfs/xfs_attr.h+0 -00 replies
3/6xfs: Add helper function xfs_attr_try_sf_addnamefs/xfs/libxfs/xfs_attr.c+30 -230 replies
4/6xfs: Add attibute set and helper functionsfs/xfs/libxfs/xfs_attr.c fs/xfs/libxfs/xfs_attr.h fs/xfs/libxfs/xfs_bmap.c +1 more+115 -870 replies
5/6xfs: Add attibute remove and helper functionsfs/xfs/libxfs/xfs_attr.c fs/xfs/libxfs/xfs_attr.h+26 -110 replies
6/6xfs: always rejoin held resources during defer rollfs/xfs/libxfs/xfs_attr.c fs/xfs/libxfs/xfs_attr.h fs/xfs/libxfs/xfs_defer.c +1 more+31 -370 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDave ChinnerDarrick J. WongBrian Foster
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] xfs: stable fixes for v4.19.y - circa v4.19.60

Sasha,

you merged my last set of XFS fixes. I asked for one patch to not be merged yet as one issue was not yet properly fixed. After some further review I have identified commits which do fix the kernel crash reported on kz#204223 [0] with generic/388, this patch set applies on top of the last one I sent you.

These commits do quite a bit of code refactoring, and the actual fix lies hidden in the last commit by Darrick. Due to the amount of changes trying to extract the fix is riskier than just carring the code refactoring. If we're OK with the code refactor for stable, its my recommendation we keep the changes to match more with upstream and benefit from other fixes. The code refactoring was merged on v4.20 and Darrick's fix is the only fix upstream since the code was merged.

If others disagree with this approach please speak up.

I've run a full set of fstests against the following sections 12 times and have found no regressions against the baseline:

xfs
xfs_logdev
xfs_nocrc_512
xfs_nocrc
xfs_realtimedev
xfs_reflink_1024
xfs_reflink_dev

Review from others is appreciated.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=204223

Allison Henderson (4):
xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h
xfs: Add helper function xfs_attr_try_sf_addname
xfs: Add attibute set and helper functions
xfs: Add attibute remove and helper functions

Brian Foster (1):
xfs: don't trip over uninitialized buffer on extent read of corrupted
inode

Darrick J. Wong (1):
xfs: always rejoin held resources during defer roll

 fs/xfs/libxfs/xfs_attr.c       | 231 ++++++++++++++++++---------------
 fs/xfs/{ => libxfs}/xfs_attr.h |   2 +
 fs/xfs/libxfs/xfs_bmap.c       |  54 +++++---
 fs/xfs/libxfs/xfs_bmap.h       |   1 +
 fs/xfs/libxfs/xfs_defer.c      |  14 +-
 fs/xfs/xfs_dquot.c             |  17 +--
 6 files changed, 183 insertions(+), 136 deletions(-)
 rename fs/xfs/{ => libxfs}/xfs_attr.h (98%)
Signature · 1 line
2.18.0