grep: PCRE JIT fixes + ab/no-kwset fix
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 16 repliesIn review
- v13 patches 9 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | grep: remove overly paranoid BUG(...) codegrep.c | +2 | 0 replies | |
| 2/8 | grep: stop "using" a custom JIT stack with PCRE v2grep.c grep.h | +0 | 1 reply | |
| 3/8 | grep: stop using a custom JIT stack with PCRE v1grep.c grep.h | +5 | 1 reply | |
| 4/8 | grep: consistently use "p->fixed" in compile_regexp()grep.c | +1 | 4 replies | |
| 5/8 | grep: create a "is_fixed" member in "grep_pat"grep.c grep.h | +4 | 0 replies | |
| 6/8 | grep: stess test PCRE v2 on invalid UTF-8 datagrep.c t/ | +38 | 13 replies | |
| 7/8 | grep: do not enter PCRE2_UTF mode on fixed matchinggrep.c t/ | +4 | 1 reply | |
| 8/8 | grep: optimistically use PCRE2_MATCH_INVALID_UTFMakefile grep.c grep.h +4 more | +31 | 21 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/8] grep: PCRE JIT fixes + ab/no-kwset fix
1-3 here are a re-roll on "next". I figured that was easier for everyone with the state of the in-flight patches, it certainly was for me. Sorry Junio if this creates a mess for you.
4-8 are a "fix" for the UTF-8 matching error noted in Carlo's "grep:
skip UTF8 checks explicitally" in
https://public-inbox.org/git/[email protected]/
As noted the bug isn't fully fixed until 8/8, and that patch relies on unreleased PCRE v2 code. I'm hoping that with 7/8 we're in a good enough state to limp forward as noted in the rationale of those commits.
Ævar Arnfjörð Bjarmason (8):
grep: remove overly paranoid BUG(...) code
grep: stop "using" a custom JIT stack with PCRE v2
grep: stop using a custom JIT stack with PCRE v1
grep: consistently use "p->fixed" in compile_regexp()
grep: create a "is_fixed" member in "grep_pat"
grep: stess test PCRE v2 on invalid UTF-8 data
grep: do not enter PCRE2_UTF mode on fixed matching
grep: optimistically use PCRE2_MATCH_INVALID_UTF
Makefile | 1 + grep.c | 68 +++++++++++---------------------- grep.h | 13 ++----- t/helper/test-pcre2-config.c | 12 ++++++ t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t7812-grep-icase-non-ascii.sh | 39 +++++++++++++++++++ 7 files changed, 80 insertions(+), 55 deletions(-) create mode 100644 t/helper/test-pcre2-config.c
Signature · 1 line
2.22.0.455.g172b71a6c5