Skip to content

grep: PCRE JIT fixes + ab/no-kwset fix

Ævar Arnfjörð Bjarmason git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 16 repliesIn review
  2. v13 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8grep: remove overly paranoid BUG(...) codegrep.c+2 -80 replies
2/8grep: stop "using" a custom JIT stack with PCRE v2grep.c grep.h+0 -141 reply
3/8grep: stop using a custom JIT stack with PCRE v1grep.c grep.h+5 -281 reply
4/8grep: consistently use "p->fixed" in compile_regexp()grep.c+1 -14 replies
5/8grep: create a "is_fixed" member in "grep_pat"grep.c grep.h+4 -40 replies
6/8grep: stess test PCRE v2 on invalid UTF-8 datagrep.c t/t7812-grep-icase-non-ascii.sh+38 -013 replies
7/8grep: do not enter PCRE2_UTF mode on fixed matchinggrep.c t/t7812-grep-icase-non-ascii.sh+4 -31 reply
8/8grep: optimistically use PCRE2_MATCH_INVALID_UTFMakefile grep.c grep.h +4 more+31 -221 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] grep: PCRE JIT fixes + ab/no-kwset fix

1-3 here are a re-roll on "next". I figured that was easier for everyone with the state of the in-flight patches, it certainly was for me. Sorry Junio if this creates a mess for you.

4-8 are a "fix" for the UTF-8 matching error noted in Carlo's "grep:
skip UTF8 checks explicitally" in
https://public-inbox.org/git/[email protected]/

As noted the bug isn't fully fixed until 8/8, and that patch relies on unreleased PCRE v2 code. I'm hoping that with 7/8 we're in a good enough state to limp forward as noted in the rationale of those commits.

Ævar Arnfjörð Bjarmason (8):
grep: remove overly paranoid BUG(...) code
grep: stop "using" a custom JIT stack with PCRE v2
grep: stop using a custom JIT stack with PCRE v1
grep: consistently use "p->fixed" in compile_regexp()
grep: create a "is_fixed" member in "grep_pat"
grep: stess test PCRE v2 on invalid UTF-8 data
grep: do not enter PCRE2_UTF mode on fixed matching
grep: optimistically use PCRE2_MATCH_INVALID_UTF

 Makefile                        |  1 +
 grep.c                          | 68 +++++++++++----------------------
 grep.h                          | 13 ++-----
 t/helper/test-pcre2-config.c    | 12 ++++++
 t/helper/test-tool.c            |  1 +
 t/helper/test-tool.h            |  1 +
 t/t7812-grep-icase-non-ascii.sh | 39 +++++++++++++++++++
 7 files changed, 80 insertions(+), 55 deletions(-)
 create mode 100644 t/helper/test-pcre2-config.c
Signature · 1 line
2.22.0.455.g172b71a6c5