Skip to content

Perf uninitialized value fixes

Numfor Mbiziwo-Tiapo lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Fix util.c use of unitialized value warningtools/perf/util/header.c+1 -11 reply
2/3Fix annotate.c use of uninitialized value errortools/perf/util/annotate.c+11 -42 replies
3/3Fix sched-messaging.c use of uninitialized value errorstools/perf/bench/sched-messaging.c+2 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Perf uninitialized value fixes

These patches are all warnings that the MSAN (Memory Sanitizer) build of perf has caught.

To build perf with MSAN enabled run:
make -C tools/perf CLANG=1 CC=clang EXTRA_CFLAGS="-fsanitize=memory\
-fsanitize-memory-track-origins"

(The -fsanitizer-memory-track-origins makes the bugs clearer but isn't strictly necessary.)

(Additionally, llvm might have to be installed and clang might have to be specified as the compiler - export CC=/usr/bin/clang).

The patches "Fix util.c use of uninitialized value warning" and "Fix annotate.c use of uninitialized value error" build on top of each other (the changes in Fix util.c use of uninitialized value warning must be made first).

When running the commands provided in the repro instructions, MSAN will generate false positive uninitialized memory errors. This is happening because libc is not MSAN-instrumented. Finding a way to build libc with MSAN will get rid of these false positives and allow the real warnings mentioned in the patches to be shown.

Numfor Mbiziwo-Tiapo (3):
Fix util.c use of uninitialized value warning Fix annotate.c use of uninitialized value error Fix sched-messaging.c use of uninitialized value errors

 tools/perf/bench/sched-messaging.c |  3 ++-
 tools/perf/util/annotate.c         | 15 +++++++++++----
 tools/perf/util/header.c           |  2 +-
 3 files changed, 14 insertions(+), 6 deletions(-)
Signature · 1 line
2.22.0.657.g960e92d24f-goog