Skip to content

synchronise meson warnings with make

Bruce Richardson dpdk-dev 2 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyApplied
  2. v14 patches 1 replySuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4build: allow compile with stricter fallthrough warningsdrivers/net/bonding/rte_eth_bond_pmd.c drivers/net/fm10k/base/meson.build lib/librte_cmdline/cmdline_parse_num.c+5 -30 replies
2/4raw/ifpga: remove unneeded compiler flagsdrivers/raw/ifpga/base/meson.build+0 -110 replies
3/4build: enable extra warnings for meson buildconfig/meson.build drivers/bus/dpaa/meson.build drivers/event/dsw/meson.build +2 more+33 -40 replies
4/4drivers: remove duplicated compiler flagsdrivers/net/fm10k/base/meson.build drivers/net/mlx4/meson.build drivers/net/mlx5/meson.build +2 more+1 -70 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchLuca Boccassi
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/4] synchronise meson warnings with make

The warnings used when building DPDK with make were stricter than those used with meson, so this patchset aligns the two as far as is possible, while also adding in -Wextra as a general compile flag.

The one difference is that with "make" we allow different flags for GCC and clang, while with meson we are (for now) keeping them common. Therefore we drop the -Wcast-align flag as is generates too many false positive warnings on clang, and we globally use the Wno-missing-field-initializers flag for the same reason.

v2: fix path to ifpga driver in patch 2, since it has moved in the repo

Bruce Richardson (4):
build: allow compile with stricter fallthrough warnings raw/ifpga: remove unneeded compiler flags
build: enable extra warnings for meson build
drivers: remove duplicated compiler flags

 config/meson.build                     | 24 +++++++++++++++++++++---
 drivers/bus/dpaa/meson.build           |  3 +++
 drivers/event/dsw/meson.build          |  3 +++
 drivers/net/bonding/rte_eth_bond_pmd.c |  3 ++-
 drivers/net/dpaa/meson.build           |  4 ++++
 drivers/net/fm10k/base/meson.build     |  3 ++-
 drivers/net/i40e/base/meson.build      |  3 ++-
 drivers/net/mlx4/meson.build           |  1 -
 drivers/net/mlx5/meson.build           |  1 -
 drivers/net/sfc/meson.build            |  2 --
 drivers/net/vdev_netvsc/meson.build    |  2 --
 drivers/raw/ifpga/base/meson.build     | 11 -----------
 lib/librte_cmdline/cmdline_parse_num.c |  2 +-
 13 files changed, 38 insertions(+), 24 deletions(-)
Signature · 1 line
2.21.0