Skip to content

KVM: arm/arm64: vgic: ITS translation cache

Marc Zyngier kvm kvmarm linux-arm-kernel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest10 patches 6 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10KVM: arm/arm64: vgic: Add LPI translation cache definitioninclude/kvm/arm_vgic.h virt/kvm/arm/vgic/vgic-init.c virt/kvm/arm/vgic/vgic-its.c +1 more+59 -00 replies
2/10KVM: arm/arm64: vgic: Add __vgic_put_lpi_locked primitivevirt/kvm/arm/vgic/vgic.c virt/kvm/arm/vgic/vgic.h+18 -90 replies
3/10KVM: arm/arm64: vgic-its: Add MSI-LPI translation cache invalidationvirt/kvm/arm/vgic/vgic-its.c virt/kvm/arm/vgic/vgic.h+24 -00 replies
4/10KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on specific commandsvirt/kvm/arm/vgic/vgic-its.c+9 -00 replies
5/10KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on disabling LPIsvirt/kvm/arm/vgic/vgic-mmio-v3.c+3 -11 reply
6/10KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on ITS disablevirt/kvm/arm/vgic/vgic-its.c+2 -01 reply
7/10KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on vgic teardownvirt/kvm/arm/vgic/vgic-its.c+2 -01 reply
8/10KVM: arm/arm64: vgic-its: Cache successful MSI->LPI translationvirt/kvm/arm/vgic/vgic-its.c+86 -00 replies
9/10KVM: arm/arm64: vgic-its: Check the LPI translation cache on MSI injectionvirt/kvm/arm/vgic/vgic-its.c virt/kvm/arm/vgic/vgic.h+37 -01 reply
10/10KVM: arm/arm64: vgic-irqfd: Implement kvm_arch_set_irq_inatomicvirt/kvm/arm/vgic/vgic-irqfd.c+30 -60 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchEric AugerAndre Przywara
SeriesT-b
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] KVM: arm/arm64: vgic: ITS translation cache

From: Marc Zyngier <[email protected]>

It recently became apparent[1] that our LPI injection path is not as efficient as it could be when injecting interrupts coming from a VFIO assigned device.

Although the proposed patch wasn't 100% correct, it outlined at least two issues:

(1) Injecting an LPI from VFIO always results in a context switch to a worker thread: no good

(2) We have no way of amortising the cost of translating a DID+EID pair to an LPI number

The reason for (1) is that we may sleep when translating an LPI, so we do need a context process. A way to fix that is to implement a small LPI translation cache that could be looked up from an atomic context. It would also solve (2).

This is what this small series proposes. It implements a very basic LRU cache of pre-translated LPIs, which gets used to implement kvm_arch_set_irq_inatomic. The size of the cache is currently hard-coded at 16 times the number of vcpus, a number I have picked under the influence of Ali Saidi. If that's not enough for you, blame me, though.

Does it work? well, it doesn't crash, and is thus perfect. More seriously, I don't really have a way to benchmark it directly, so my observations are only indirect:

On a TX2 system, I run a 4 vcpu VM with an Ethernet interface passed to it directly. From the host, I inject interrupts using debugfs. In parallel, I look at the number of context switch, and the number of interrupts on the host. Without this series, I get the same number for both IRQ and CS (about half a million of each per second is pretty easy to reach). With this series, the number of context switches drops to something pretty small (in the low 2k), while the number of interrupts stays the same.

Yes, this is a pretty rubbish benchmark, what did you expect? ;-)

Andre did run some benchmarks of his own, with some rather positive results[2]. So I'm putting this out for people with real workloads to try out and report what they see.

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://www.spinics.net/lists/arm-kernel/msg742655.html

* From v2:

- Added invalidation on turning the ITS off
- Added invalidation on MAPC with V=0
- Added Rb's from Eric

* From v1:

- Fixed race on allocation, where the same LPI could be cached multiple times
- Now invalidate the cache on vgic teardown, avoiding memory leaks
- Change patch split slightly, general reshuffling
- Small cleanups here and there
- Rebased on 5.2-rc4

Marc Zyngier (10):
KVM: arm/arm64: vgic: Add LPI translation cache definition
KVM: arm/arm64: vgic: Add __vgic_put_lpi_locked primitive
KVM: arm/arm64: vgic-its: Add MSI-LPI translation cache invalidation
KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on
specific commands
KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on
disabling LPIs
KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on ITS
disable
KVM: arm/arm64: vgic-its: Invalidate MSI-LPI translation cache on vgic
teardown
KVM: arm/arm64: vgic-its: Cache successful MSI->LPI translation
KVM: arm/arm64: vgic-its: Check the LPI translation cache on MSI
injection
KVM: arm/arm64: vgic-irqfd: Implement kvm_arch_set_irq_inatomic

 include/kvm/arm_vgic.h           |   3 +
 virt/kvm/arm/vgic/vgic-init.c    |   5 +
 virt/kvm/arm/vgic/vgic-irqfd.c   |  36 +++++-
 virt/kvm/arm/vgic/vgic-its.c     | 207 +++++++++++++++++++++++++++++++
 virt/kvm/arm/vgic/vgic-mmio-v3.c |   4 +-
 virt/kvm/arm/vgic/vgic.c         |  26 ++--
 virt/kvm/arm/vgic/vgic.h         |   5 +
 7 files changed, 270 insertions(+), 16 deletions(-)
Signature · 1 line
2.20.1