Skip to content

block-backend: Queue requests while drained

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v14 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Rebased on top of block-next
- Replaced patch 2 with draining mirror_top_bs instead [Max]
- Removed wait_while_drained parameter from patch 3 [Max]
- Covered blk_co_flush() [Max]
- Fixed some typos [Eric]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: Remove blk_pread_unthrottled()block/block-backend.c hw/block/hd-geometry.c include/sysemu/block-backend.h+1 -240 replies
2/3mirror: Keep mirror_top_bs drained after dropping permissionsblock/mirror.c+5 -11 reply
3/3block-backend: Queue requests while drainedblock/backup.c block/block-backend.c block/commit.c +4 more+59 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] block-backend: Queue requests while drained

This series fixes the problem that devices like IDE, which submit requests as a direct result of I/O from the CPU thread, can continue to submit new requests even in a drained section.

v2:
- Rebased on top of block-next
- Replaced patch 2 with draining mirror_top_bs instead [Max]
- Removed wait_while_drained parameter from patch 3 [Max]
- Covered blk_co_flush() [Max]
- Fixed some typos [Eric]

Kevin Wolf (3):
block: Remove blk_pread_unthrottled()
mirror: Keep mirror_top_bs drained after dropping permissions
block-backend: Queue requests while drained

 include/sysemu/block-backend.h |  3 +-
 block/backup.c                 |  1 +
 block/block-backend.c          | 69 ++++++++++++++++++++++++----------
 block/commit.c                 |  2 +
 block/mirror.c                 |  7 +++-
 blockjob.c                     |  3 ++
 hw/block/hd-geometry.c         |  7 +---
 tests/test-bdrv-drain.c        |  1 +
 8 files changed, 65 insertions(+), 28 deletions(-)
Signature · 1 line
2.20.1