Skip to content

NFC: nxp-nci: clean up and new device support

Andy Shevchenko netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 3 repliesIn review
  2. v314 patches 6 repliesSuperseded

Changes in v4 from the cover letter

- rebased on top of latest linux-next
- appended cover letter
- elaborated removal of pr_fmt() in the patch 11 (David)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14NFC: fix attrs checks in netlink interfacenet/nfc/netlink.c+4 -20 replies
2/14NFC: nxp-nci: Add NXP1001 to the ACPI ID tabledrivers/nfc/nxp-nci/i2c.c+1 -00 replies
3/14NFC: nxp-nci: Get rid of platform dataMAINTAINERS drivers/nfc/nxp-nci/core.c drivers/nfc/nxp-nci/i2c.c +2 more+1 -300 replies
4/14NFC: nxp-nci: Convert to use GPIO descriptordrivers/nfc/nxp-nci/core.c drivers/nfc/nxp-nci/i2c.c+15 -460 replies
5/14NFC: nxp-nci: Add GPIO ACPI mapping tabledrivers/nfc/nxp-nci/i2c.c+16 -20 replies
6/14NFC: nxp-nci: Get rid of code duplication in ->probe()drivers/nfc/nxp-nci/i2c.c+15 -530 replies
7/14NFC: nxp-nci: Get rid of useless labeldrivers/nfc/nxp-nci/i2c.c+4 -80 replies
8/14NFC: nxp-nci: Constify acpi_device_iddrivers/nfc/nxp-nci/i2c.c+1 -10 replies
9/14NFC: nxp-nci: Drop of_match_ptr() usedrivers/nfc/nxp-nci/i2c.c+1 -10 replies
10/14NFC: nxp-nci: Drop comma in terminator linesdrivers/nfc/nxp-nci/i2c.c+2 -20 replies
11/14NFC: nxp-nci: Remove unused macro pr_fmt()drivers/nfc/nxp-nci/i2c.c+0 -20 replies
12/14NFC: nxp-nci: Remove 'default n' for the coredrivers/nfc/nxp-nci/Kconfig+0 -10 replies
13/14NFC: nxp-nci: Clarify on supported chipsdrivers/nfc/nxp-nci/Kconfig+2 -20 replies
14/14NFC: nxp-nci: Fix recommendation for NFC_NXP_NCI_I2C Kconfigdrivers/nfc/nxp-nci/Kconfig+1 -10 replies

Reviews trailers per patch

1 of 14 patches has a Reviewed-by or Acked-by.

PatchSedat DilekOleg Zhurakivskyy
1/14
2/14T-b
3/14T-b
4/14T-b
5/14T-b
6/14T-b
7/14T-b
8/14T-b
9/14T-b
10/14T-b
11/14T-b
12/14T-b
13/14A-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/14] NFC: nxp-nci: clean up and new device support

Few people reported that some laptops are coming with new ACPI ID for the devices should be supported by nxp-nci driver.

This series adds new ID (patch 2), cleans up the driver from legacy platform data and unifies GPIO request for Device Tree and ACPI (patches 3-6), removes dead or unneeded code (patches 7, 9, 11), constifies ID table (patch 8), removes comma in terminator line for better maintenance (patch 10) and rectifies Kconfig entry (patches 12-14).

It also contains a fix for NFC subsystem as suggested by Sedat.

Series has been tested by Sedat.

Changelog v4:
- rebased on top of latest linux-next
- appended cover letter
- elaborated removal of pr_fmt() in the patch 11 (David)

Andrey Konovalov (1):
NFC: fix attrs checks in netlink interface

Andy Shevchenko (11):
NFC: nxp-nci: Add NXP1001 to the ACPI ID table
NFC: nxp-nci: Get rid of platform data
NFC: nxp-nci: Convert to use GPIO descriptor
NFC: nxp-nci: Add GPIO ACPI mapping table
NFC: nxp-nci: Get rid of code duplication in ->probe()
NFC: nxp-nci: Get rid of useless label
NFC: nxp-nci: Constify acpi_device_id
NFC: nxp-nci: Drop of_match_ptr() use
NFC: nxp-nci: Drop comma in terminator lines
NFC: nxp-nci: Remove unused macro pr_fmt()
NFC: nxp-nci: Remove 'default n' for the core

Sedat Dilek (2):
NFC: nxp-nci: Clarify on supported chips
NFC: nxp-nci: Fix recommendation for NFC_NXP_NCI_I2C Kconfig

 MAINTAINERS                           |   1 -
 drivers/nfc/nxp-nci/Kconfig           |   7 +-
 drivers/nfc/nxp-nci/core.c            |   2 -
 drivers/nfc/nxp-nci/i2c.c             | 134 +++++++-------------------
 drivers/nfc/nxp-nci/nxp-nci.h         |   1 -
 include/linux/platform_data/nxp-nci.h |  19 ----
 net/nfc/netlink.c                     |   6 +-
 7 files changed, 41 insertions(+), 129 deletions(-)
 delete mode 100644 include/linux/platform_data/nxp-nci.h
Signature · 1 line
2.20.1