Skip to content

iotests: use python logging

John Snow qemu-devel 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest14 patches 26 repliesIn review
  2. v914 patches 24 repliesSuperseded
  3. v811 patches 14 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v710 patches11 repliesSuperseded
v69 patches24 repliesSuperseded
v55 patches38 repliesSuperseded
v44 patches14 repliesSuperseded
v34 patches10 repliesSuperseded
v23 patches7 repliesSuperseded
v12 patches4 repliesSuperseded

V9 from the cover letter

006: New.
007: Split from old patch.
008: Split from old patch; enhanced a little to justify its own patch. 010: New, pulled in from bitmap-populate series. Helps line length. 011: Reflow columns for long typing import list. (Kept RB.) 014: New blank line. (Kept RB.)

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14iotests: do a light delintingtests/qemu-iotests/iotests.py+43 -400 replies
2/14iotests: don't use 'format' for drive_addtests/qemu-iotests/055 tests/qemu-iotests/iotests.py+5 -40 replies
3/14iotests: ignore import warnings from pylinttests/qemu-iotests/iotests.py+1 -00 replies
4/14iotests: replace mutable list default argstests/qemu-iotests/iotests.py+12 -120 replies
5/14iotests: add pylintrc filetests/qemu-iotests/pylintrc+22 -00 replies
6/14iotests: alphabetize standard importstests/qemu-iotests/iotests.py+9 -91 reply
7/14iotests: drop pre-Python 3.4 compatibility codetests/qemu-iotests/iotests.py+1 -40 replies
8/14iotests: touch up log function signaturetests/qemu-iotests/iotests.py+11 -30 replies
9/14iotests: limit line length to 79 charstests/qemu-iotests/iotests.py tests/qemu-iotests/pylintrc+47 -230 replies
10/14iotests: add hmp helper with loggingtests/qemu-iotests/iotests.py+22 -1313 replies
11/14iotests: add script_initializetests/qemu-iotests/149 tests/qemu-iotests/194 tests/qemu-iotests/202 +34 more+130 -810 replies
12/14iotest 258: use script_maintests/qemu-iotests/258+4 -70 replies
13/14iotests: Mark verify functions as privatetests/qemu-iotests/iotests.py+13 -101 reply
14/14iotests: use python logging for iotests.log()tests/qemu-iotests/030 tests/qemu-iotests/155 tests/qemu-iotests/245 +2 more+46 -386 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéMax ReitzKevin Wolf
SeriesR-b
1/14R-b R-b
2/14R-b R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b
6/14R-b R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v10 thread

Cover letter [PATCH v10 00/14] iotests: use python logging

This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests.

It will help alleviate the need to create logged/unlogged versions of all the various helpers we have made.

Also, I got lost and accidentally delinted iotests while I was here. Sorry about that. By version 9, it's now the overwhelming focus of this series. No good deed, etc.

V10:

001/14:[0004] [FC] 'iotests: do a light delinting' 002/14:[----] [--] 'iotests: don't use 'format' for drive_add' 003/14:[----] [--] 'iotests: ignore import warnings from pylint' 004/14:[----] [--] 'iotests: replace mutable list default args' 005/14:[0006] [FC] 'iotests: add pylintrc file' 006/14:[----] [--] 'iotests: alphabetize standard imports' 007/14:[----] [--] 'iotests: drop pre-Python 3.4 compatibility code' 008/14:[----] [--] 'iotests: touch up log function signature' 009/14:[----] [-C] 'iotests: limit line length to 79 chars' 010/14:[0009] [FC] 'iotests: add hmp helper with logging' 011/14:[0019] [FC] 'iotests: add script_initialize' 012/14:[----] [--] 'iotest 258: use script_main' 013/14:[0013] [FC] 'iotests: Mark verify functions as private' 014/14:[0001] [FC] 'iotests: use python logging for iotests.log()'

001: replace "atom" name with "item". Kept RBs.
005: Alphabetized excluded warnings list. Kept RBs.
Kevin's comments addressed by using pylint >= 2.2.0
009: Added Max's RB.
Updated commit message based on Max's response
Kevin's comments addressed by mypy >= 0.620
010: Fixed type hints (Kevin)
011: Replace 'Collection' with 'Sequence' to work around pylint/python 3.6 013: Update type signatures of _verify functions (Kevin)
014: Minor whitespace changes as the fault handler gets shuffled around.

V9:
006: New.
007: Split from old patch.
008: Split from old patch; enhanced a little to justify its own patch. 010: New, pulled in from bitmap-populate series. Helps line length. 011: Reflow columns for long typing import list. (Kept RB.) 014: New blank line. (Kept RB.)

V8:
- Split out the little drop of Python 3.4 code. (Phil)
- Change line continuation styles (QEMU Memorial Choir)
- Rebase changes; remove use_log from more places, adjust test output.

V7:
- All delinting patches are now entirely front-loaded.
- Redid delinting to avoid "correcting" no-else-return statements.
- Moved more mutable list corrections into patch 4, to make it standalone.
- Moved pylintrc up to patch 5. Disabled no-else-return.
- Added patch 6 to require line length checks.
(Some python 3.4 compatibility code is removed as a consequence.)
- Patch 7 changes slightly as a result of patch 4 changes.
- Added some logging explainer into patch 10.
(Patch changes slightly because of patch 6.)

V6:
- It's been so long since V5, let's just look at it anew.

John Snow (14):
iotests: do a light delinting
iotests: don't use 'format' for drive_add
iotests: ignore import warnings from pylint
iotests: replace mutable list default args
iotests: add pylintrc file
iotests: alphabetize standard imports
iotests: drop pre-Python 3.4 compatibility code
iotests: touch up log function signature
iotests: limit line length to 79 chars
iotests: add hmp helper with logging
iotests: add script_initialize
iotest 258: use script_main
iotests: Mark verify functions as private
iotests: use python logging for iotests.log()

 tests/qemu-iotests/030        |   4 +-
 tests/qemu-iotests/055        |   3 +-
 tests/qemu-iotests/149        |   3 +-
 tests/qemu-iotests/155        |   2 +-
 tests/qemu-iotests/194        |   4 +-
 tests/qemu-iotests/202        |   4 +-
 tests/qemu-iotests/203        |   4 +-
 tests/qemu-iotests/206        |   2 +-
 tests/qemu-iotests/207        |   6 +-
 tests/qemu-iotests/208        |   2 +-
 tests/qemu-iotests/209        |   2 +-
 tests/qemu-iotests/210        |   6 +-
 tests/qemu-iotests/211        |   6 +-
 tests/qemu-iotests/212        |   6 +-
 tests/qemu-iotests/213        |   6 +-
 tests/qemu-iotests/216        |   4 +-
 tests/qemu-iotests/218        |   2 +-
 tests/qemu-iotests/219        |   2 +-
 tests/qemu-iotests/222        |   7 +-
 tests/qemu-iotests/224        |   4 +-
 tests/qemu-iotests/228        |   6 +-
 tests/qemu-iotests/234        |   4 +-
 tests/qemu-iotests/235        |   4 +-
 tests/qemu-iotests/236        |   2 +-
 tests/qemu-iotests/237        |   2 +-
 tests/qemu-iotests/238        |   2 +
 tests/qemu-iotests/242        |   2 +-
 tests/qemu-iotests/245        |   1 +
 tests/qemu-iotests/245.out    |  24 +--
 tests/qemu-iotests/246        |   2 +-
 tests/qemu-iotests/248        |   2 +-
 tests/qemu-iotests/254        |   2 +-
 tests/qemu-iotests/255        |   2 +-
 tests/qemu-iotests/256        |   2 +-
 tests/qemu-iotests/258        |  10 +-
 tests/qemu-iotests/260        |   4 +-
 tests/qemu-iotests/262        |   4 +-
 tests/qemu-iotests/264        |   4 +-
 tests/qemu-iotests/277        |   2 +
 tests/qemu-iotests/280        |   8 +-
 tests/qemu-iotests/283        |   4 +-
 tests/qemu-iotests/iotests.py | 366 ++++++++++++++++++++--------------
 tests/qemu-iotests/pylintrc   |  26 +++
 43 files changed, 343 insertions(+), 221 deletions(-)
 create mode 100644 tests/qemu-iotests/pylintrc
Signature · 1 line
2.21.1