Skip to content

lib/vdso, x86/vdso: Fix fallout from generic VDSO conversion

Thomas Gleixner lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5lib/vdso/32: Remove inconsistent NULL pointer checkslib/vdso/gettimeofday.c+2 -164 replies
2/5lib/vdso: Move fallback invocation to the callerslib/vdso/gettimeofday.c+36 -172 replies
3/5lib/vdso/32: Provide legacy syscall fallbackslib/vdso/gettimeofday.c+45 -17 replies
4/5x86/vdso/32: Use 32bit syscall fallbackarch/x86/include/asm/vdso/gettimeofday.h+36 -03 replies
5/5arm64: compat: vdso: Use legacy syscalls as fallbackarch/arm64/include/asm/vdso/compat_gettimeofday.h+40 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAndy LutomirskiVincenzo FrascinoSean Christopherson
1/5R-b R-b T-b
2/5R-b R-b T-b
3/5R-b R-b T-b Reviewed-and-tested-by
4/5R-b R-b Reviewed-and-tested-by
5/5R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [patch 0/5] lib/vdso, x86/vdso: Fix fallout from generic VDSO conversion

Several reporters noticed a regression with the new VDSO. 32bit user space applications are tripping over seccomp filters with 5.3-rc. The reason is that the 32bit VDSO syscall fallback uses clock_gettime64()/getres64() for simplicity reasons. Existing seccomp filters do not enable the new 64bit syscalls and prevent the applications from working correctly.

The following series addresses this by using the legacy 32bit syscall as fallback in 32bit VDSOs.

Note, using the legacy syscall fallback is opt-in for now because otherwise architectures which have their conversion queued in -next would break.

Once all are converted over, the conditional and the 64bit fallback implementation can be removed.

Thanks,

tglx

8<--------------

 arch/arm64/include/asm/vdso/compat_gettimeofday.h |   40 +++++++
 arch/x86/include/asm/vdso/gettimeofday.h          |   36 +++++++
 lib/vdso/gettimeofday.c                           |  111 +++++++++++++++-------
 3 files changed, 156 insertions(+), 31 deletions(-)