Skip to content

system header cleanup

Carlo Marcelo Arenas Belón git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest5 patches 2 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5verify-tag: drop signal.h includebuiltin/verify-commit.c builtin/verify-tag.c+0 -20 replies
2/5wt-status.h: drop stdio.h includewt-status.h+0 -10 replies
3/5xdiff: drop system includes in xutils.cxdiff/xutils.c+0 -40 replies
4/5xdiff: remove duplicate headers from xhistogram.cxdiff/xhistogram.c+0 -20 replies
5/5xdiff: remove duplicate headers from xpatience.cxdiff/xpatience.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] system header cleanup

This series is a reroll of jk/no-system-includes-in-dot-c with cb/xdiff-no-system-includes-in-dot-c applied on top with minor fixes for the commit message based on feedback from Johannes and the example put forward by Peff with his own patches.

The changes proposed shouldn't affect any systems (except for the 3rd one) and that has since shown to also be needed in Alpine Linux (because of _XOPEN_SOURCE redefinition).

The last 2 patches are new to the series and just cleanup the dependency list in xdiff.

Carlo Marcelo Arenas Belón (3):
xdiff: drop system includes in xutils.c
xdiff: remove duplicate headers from xhistogram.c
xdiff: remove duplicate headers from xpatience.c

Jeff King (2):
verify-tag: drop signal.h include
wt-status.h: drop stdio.h include

 builtin/verify-commit.c | 1 -
 builtin/verify-tag.c    | 1 -
 wt-status.h             | 1 -
 xdiff/xhistogram.c      | 2 --
 xdiff/xpatience.c       | 2 --
 xdiff/xutils.c          | 4 ----
 6 files changed, 11 deletions(-)
Signature · 1 line
2.22.0