Skip to content

powerpc/64s/exception: cleanup and gas macroify, round 2

Nicholas Piggin linuxppc-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18powerpc/64s/exception: Fix DAR load for handle_page_fault error casearch/powerpc/kernel/exceptions-64s.S+1 -10 replies
2/18powerpc/64s/exception: move head-64.h exception code to exception-64s.Sarch/powerpc/include/asm/head-64.h arch/powerpc/kernel/exceptions-64s.S+41 -410 replies
3/18powerpc/64s/exception: Add EXC_HV_OR_STD, for HSRR if HV=1 else SRRarch/powerpc/kernel/exceptions-64s.S+79 -230 replies
4/18powerpc/64s/exception: Fix performance monitor virt handlerarch/powerpc/kernel/exceptions-64s.S+1 -10 replies
5/18powerpc/64s/exception: remove 0xb00 handlerarch/powerpc/kernel/exceptions-64s.S+2 -40 replies
6/18powerpc/64s/exception: Replace PROLOG macros and EXC helpers with a gas macroarch/powerpc/kernel/exceptions-64s.S+206 -2960 replies
7/18powerpc/64s/exception: remove EXCEPTION_PROLOG_0/1, rename _2arch/powerpc/kernel/exceptions-64s.S+73 -780 replies
8/18powerpc/64s/exception: Add the virt variant of the denorm interrupt handlerarch/powerpc/kernel/exceptions-64s.S+5 -10 replies
9/18powerpc/64s/exception: INT_HANDLER support HDAR/HDSISR and use it in HDSIarch/powerpc/kernel/exceptions-64s.S+10 -60 replies
10/18powerpc/64s/exception: Add INT_KVM_HANDLER gas macroarch/powerpc/kernel/exceptions-64s.S+40 -590 replies
11/18powerpc/64s/exception: KVM_HANDLER reorder arguments to match other macrosarch/powerpc/kernel/exceptions-64s.S+8 -80 replies
12/18powerpc/64s/exception: Merge EXCEPTION_PROLOG_COMMON_2/3arch/powerpc/kernel/exceptions-64s.S+6 -120 replies
13/18powerpc/64s/exception: Add INT_COMMON gas macro to generate common exception codearch/powerpc/kernel/exceptions-64s.S+32 -200 replies
14/18powerpc/64s/exception: Expand EXCEPTION_COMMON macro into callerarch/powerpc/kernel/exceptions-64s.S+27 -270 replies
15/18powerpc/64s/exception: Expand EXCEPTION_PROLOG_COMMON_1 and 2 into callerarch/powerpc/kernel/exceptions-64s.S+40 -450 replies
16/18powerpc/64s/exception: INT_COMMON add DIR, DSISR, reconcile optionsarch/powerpc/kernel/exceptions-64s.S+51 -600 replies
17/18powerpc/64s/exception: move interrupt entry code above the common handlerarch/powerpc/kernel/exceptions-64s.S+225 -2250 replies
18/18powerpc/64s/exception: program check handler do not branch into a macroarch/powerpc/kernel/exceptions-64s.S+8 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/18] powerpc/64s/exception: cleanup and gas macroify, round 2

This series goes on top of the unmerged machine check handler changes

https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=118814

This carries on with the goal of unwinding macros and consolidating code. This gets most of the way there, but we have traded that improvement for another problem, which is the argument list for code generation macros is unwieldy.

INT_HANDLER system_reset, 0x100, 0, 0, 0, EXC_STD, PACA_EXNMI, 0, 0, 0, 0, 1

There are two possible ways I see to solve this. One is to come up with new sets of constants for each argument.

INT_HANDLER system_reset, 0x100, INLINE, FULL, REAL, EXC_STD, PACA_EXNMI, CLEAR_RI, NO_DAR, NO_DSISR, NO_MASK, KVM

I don't really like that, my preferred way is we can set symbols to configure the behaviour of the code generation macro.

INT_DEFINE_BEGIN(system_reset)

          IVEC=0x100
          IHSRR=0
          IAREA=PACA_EXNMI
          ISET_RI=0
          IKVM_REAL=1

INT_DEFINE_END(data_access)

INT_HANDLER system_reset

Any other suggestions?

Thanks,
Nick

Nicholas Piggin (18):
powerpc/64s/exception: Fix DAR load for handle_page_fault error case powerpc/64s/exception: move head-64.h exception code to

    exception-64s.S

powerpc/64s/exception: Add EXC_HV_OR_STD, for HSRR if HV=1 else SRR powerpc/64s/exception: Fix performance monitor virt handler powerpc/64s/exception: remove 0xb00 handler powerpc/64s/exception: Replace PROLOG macros and EXC helpers with a
gas macro
powerpc/64s/exception: remove EXCEPTION_PROLOG_0/1, rename _2 powerpc/64s/exception: Add the virt variant of the denorm interrupt
handler
powerpc/64s/exception: INT_HANDLER support HDAR/HDSISR and use it in
HDSI
powerpc/64s/exception: Add INT_KVM_HANDLER gas macro powerpc/64s/exception: KVM_HANDLER reorder arguments to match other
macros
powerpc/64s/exception: Merge EXCEPTION_PROLOG_COMMON_2/3 powerpc/64s/exception: Add INT_COMMON gas macro to generate common
exception code
powerpc/64s/exception: Expand EXCEPTION_COMMON macro into caller powerpc/64s/exception: Expand EXCEPTION_PROLOG_COMMON_1 and 2 into
caller
powerpc/64s/exception: INT_COMMON add DIR, DSISR, reconcile options powerpc/64s/exception: move interrupt entry code above the common
handler
powerpc/64s/exception: program check handler do not branch into a
macro

 arch/powerpc/include/asm/head-64.h   |   41 -
 arch/powerpc/kernel/exceptions-64s.S | 1264 +++++++++++++-------------
 2 files changed, 623 insertions(+), 682 deletions(-)
Signature · 1 line
2.22.0