Skip to content

RDMA: Cleanups and improvements

Kamal Heib linux-rdma 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesIn review
  2. v34 patches 4 repliesSuperseded
  3. v24 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Patch #1:
-- Introduce phys_state_to_str() and use it.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4RDMA: Introduce ib_port_phys_state enumdrivers/infiniband/core/sysfs.c drivers/infiniband/hw/bnxt_re/ib_verbs.c drivers/infiniband/hw/efa/efa_verbs.c +12 more+53 -430 replies
2/4RDMA/cxgb3: Use ib_device_set_netdev()drivers/infiniband/hw/cxgb3/iwch_provider.c+20 -00 replies
3/4RDMA/core: Add common iWARP query portdrivers/infiniband/core/device.c+71 -160 replies
4/4RDMA/{cxgb3, cxgb4, i40iw}: Remove common codedrivers/infiniband/hw/cxgb3/iwch_provider.c drivers/infiniband/hw/cxgb4/provider.c drivers/infiniband/hw/i40iw/i40iw_verbs.c+0 -600 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchPotnuri Bharat TejaAndrew BoyerMichal KalderonBernard Metzler
1/4R-b A-b A-b
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH for-next V4 0/4] RDMA: Cleanups and improvements

This series includes few cleanups and improvements, the first patch introduce a new enum for describing the physical state values and use it instead of using the magic numbers, patch 2-4 add support for a common query port for iWARP drivers and remove the common code from the iWARP drivers.

Changes from v3:
- Patch #1:
-- Introduce phys_state_to_str() and use it.

Changes from v2:
- Patch #1:
-- Update mlx4 and hns to use the new ib_port_phys_state enum.
- Patch #3:
-- Use rdma_protocol_iwarp() instead of rdma_node_get_transport().

Changes from v1 :
- Patch #3:
-- Delete __ prefix.
-- Add missing dev_put(netdev);
-- Initilize gid to {}.
-- Return error code directly.

Kamal Heib (4):
RDMA: Introduce ib_port_phys_state enum
RDMA/cxgb3: Use ib_device_set_netdev()
RDMA/core: Add common iWARP query port
RDMA/{cxgb3, cxgb4, i40iw}: Remove common code

 drivers/infiniband/core/device.c             | 87 ++++++++++++++++----
 drivers/infiniband/core/sysfs.c              | 30 ++++---
 drivers/infiniband/hw/bnxt_re/ib_verbs.c     |  4 +-
 drivers/infiniband/hw/cxgb3/iwch_provider.c  | 45 +++++-----
 drivers/infiniband/hw/cxgb4/provider.c       | 24 ------
 drivers/infiniband/hw/efa/efa_verbs.c        |  2 +-
 drivers/infiniband/hw/hns/hns_roce_device.h  | 10 ---
 drivers/infiniband/hw/hns/hns_roce_main.c    |  3 +-
 drivers/infiniband/hw/i40iw/i40iw_verbs.c    | 11 ---
 drivers/infiniband/hw/mlx4/main.c            |  3 +-
 drivers/infiniband/hw/mlx5/main.c            |  4 +-
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c  |  4 +-
 drivers/infiniband/hw/qedr/verbs.c           |  4 +-
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c |  7 +-
 drivers/infiniband/sw/rxe/rxe.h              |  4 -
 drivers/infiniband/sw/rxe/rxe_param.h        |  2 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c        |  6 +-
 drivers/infiniband/sw/siw/siw_verbs.c        |  3 +-
 include/rdma/ib_verbs.h                      | 10 +++
 19 files changed, 144 insertions(+), 119 deletions(-)
Signature · 1 line
2.20.1