Skip to content

Further RAS enablement for vega20

Alex Deucher amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest26 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26drm/amdgpu: move some ras data structure to amdgpu_ras.hdrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h+68 -690 replies
2/26drm/amdgpu: init RSMU and UMC ip base address for vega20drivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c+4 -00 replies
3/26drm/amdgpu: add amdgpu_umc_functions structuredrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h+31 -00 replies
4/26drm/amdgpu: add rsmu v_0_0_2 ip headersdrivers/gpu/drm/amd/include/asic_reg/rsmu/rsmu_0_0_2_offset.h drivers/gpu/drm/amd/include/asic_reg/rsmu/rsmu_0_0_2_sh_mask.h+59 -00 replies
5/26drm/amdgpu: add umc v6_1_1 IP headersdrivers/gpu/drm/amd/include/asic_reg/umc/umc_6_1_1_offset.h drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_1_1_sh_mask.h+122 -00 replies
6/26drm/amdgpu: add umc v6_1 query error count supportdrivers/gpu/drm/amd/amdgpu/Makefile drivers/gpu/drm/amd/amdgpu/umc_v6_1.c drivers/gpu/drm/amd/amdgpu/umc_v6_1.h+205 -00 replies
7/26drm/amdgpu: init umc v6_1 functions for vega20drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c+14 -00 replies
8/26drm/amdgpu: querry umc error countdrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c+13 -10 replies
9/26drm/amdgpu: add ras error count after each query (v2)drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c+11 -00 replies
10/26drm/amdgpu: add RREG64/WREG64(_PCIE) operationsdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/soc15.c+129 -00 replies
11/26drm/amdgpu: use 64bit operation macros for umcdrivers/gpu/drm/amd/amdgpu/umc_v6_1.c+8 -170 replies
12/26drm/amdgpu: switch to amdgpu_umc structuredrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h +1 more+16 -60 replies
13/26drm/amdgpu: update algorithm of umc uncorrectable error countingdrivers/gpu/drm/amd/amdgpu/umc_v6_1.c+6 -60 replies
14/26drm/amdgpu: add support for recording ras error addressdrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h+3 -10 replies
15/26drm/amdgpu: add structures for umc error address translationdrivers/gpu/drm/amd/amdgpu/amdgpu_umc.h drivers/gpu/drm/amd/amdgpu/umc_v6_1.c+12 -00 replies
16/26drm/amdgpu: query umc ras error addressdrivers/gpu/drm/amd/amdgpu/umc_v6_1.c+80 -00 replies
17/26drm/amdgpu: allow ras interrupt callback to return error datadrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h+22 -210 replies
18/26drm/amdgpu: update interrupt callback for all ras clientsdrivers/gpu/drm/amd/amdgpu/gfx_v9_0.c drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c+6 -20 replies
19/26drm/amdgpu: add check for ras error typedrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c+8 -30 replies
20/26drm/amdgpu: remove ras_reserve_vram in ras injectiondrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c+10 -110 replies
21/26drm/amd/include: add bitfield define for EDC registersdrivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_sh_mask.h+157 -00 replies
22/26drm/amd/include: add define of TCP_EDC_CNT_NEWdrivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_offset.h+2 -00 replies
23/26drm/amdgpu: add define for gfx ras subblockdrivers/gpu/drm/amd/amdgpu/amdgpu_ras.h drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c+431 -00 replies
24/26drm/amdgpu: add RAS callback for gfxdrivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c+531 -11 reply
25/26drm/amdgpu: support gfx ras error injection and err_cnt querydrivers/gpu/drm/amd/amdgpu/amdgpu_ras.c drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c+18 -30 replies
26/26drm/amdgpu: disable inject for failed subblocks of gfxdrivers/gpu/drm/amd/amdgpu/gfx_v9_0.c+165 -1160 replies

Reviews trailers per patch

All 26 patches have a Reviewed-by or Acked-by.

PatchDennis LiHawking ZhangTao Zhou
1/26R-b
2/26R-b
3/26R-b
4/26R-b
5/26R-b
6/26R-b
7/26R-b
8/26R-b
9/26R-b
10/26R-b
11/26R-b
12/26R-b
13/26R-b R-b
14/26R-b R-b
15/26R-b
16/26R-b R-b
17/26R-b R-b
18/26R-b R-b
19/26R-b R-b
20/26R-b R-b
21/26R-b R-b
22/26R-b R-b
23/26R-b R-b
24/26R-b R-b
25/26R-b R-b
26/26R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/26] Further RAS enablement for vega20

This series enables additional RAS features for vega20.

Dennis Li (6):
drm/amd/include: add bitfield define for EDC registers drm/amd/include: add define of TCP_EDC_CNT_NEW drm/amdgpu: add define for gfx ras subblock drm/amdgpu: add RAS callback for gfx
drm/amdgpu: support gfx ras error injection and err_cnt query drm/amdgpu: disable inject for failed subblocks of gfx

Hawking Zhang (8):
drm/amdgpu: move some ras data structure to amdgpu_ras.h drm/amdgpu: init RSMU and UMC ip base address for vega20 drm/amdgpu: add amdgpu_umc_functions structure drm/amdgpu: add rsmu v_0_0_2 ip headers drm/amdgpu: add umc v6_1_1 IP headers drm/amdgpu: add umc v6_1 query error count support drm/amdgpu: init umc v6_1 functions for vega20 drm/amdgpu: querry umc error count

Tao Zhou (12):
drm/amdgpu: add ras error count after each query (v2) drm/amdgpu: add RREG64/WREG64(_PCIE) operations drm/amdgpu: use 64bit operation macros for umc drm/amdgpu: switch to amdgpu_umc structure drm/amdgpu: update algorithm of umc uncorrectable error counting drm/amdgpu: add support for recording ras error address drm/amdgpu: add structures for umc error address translation drm/amdgpu: query umc ras error address
drm/amdgpu: allow ras interrupt callback to return error data drm/amdgpu: update interrupt callback for all ras clients drm/amdgpu: add check for ras error type
drm/amdgpu: remove ras_reserve_vram in ras injection

 drivers/gpu/drm/amd/amdgpu/Makefile           |   4 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |  17 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  73 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h       |   2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c       | 145 ++--
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h       | 308 ++++++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h       |  37 +
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c         | 784 +++++++++++++++++-
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  19 +
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c        |   2 +
 drivers/gpu/drm/amd/amdgpu/soc15.c            |  45 +
 drivers/gpu/drm/amd/amdgpu/umc_v6_1.c         | 243 ++++++
 drivers/gpu/drm/amd/amdgpu/umc_v6_1.h         |  39 +
 drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c  |   2 +
 .../amd/include/asic_reg/gc/gc_9_0_offset.h   |   2 +
 .../amd/include/asic_reg/gc/gc_9_0_sh_mask.h  | 157 ++++
 .../include/asic_reg/rsmu/rsmu_0_0_2_offset.h |  27 +
 .../asic_reg/rsmu/rsmu_0_0_2_sh_mask.h        |  32 +
 .../include/asic_reg/umc/umc_6_1_1_offset.h   |  31 +
 .../include/asic_reg/umc/umc_6_1_1_sh_mask.h  |  91 ++
 20 files changed, 1967 insertions(+), 93 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h
 create mode 100644 drivers/gpu/drm/amd/amdgpu/umc_v6_1.c
 create mode 100644 drivers/gpu/drm/amd/amdgpu/umc_v6_1.h
 create mode 100644 drivers/gpu/drm/amd/include/asic_reg/rsmu/rsmu_0_0_2_offset.h
 create mode 100644 drivers/gpu/drm/amd/include/asic_reg/rsmu/rsmu_0_0_2_sh_mask.h
 create mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_1_1_offset.h
 create mode 100644 drivers/gpu/drm/amd/include/asic_reg/umc/umc_6_1_1_sh_mask.h
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx