Skip to content

RFC Revert tc batchsize feature

Stephen Hemminger netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Revert "tc: Remove pointless assignments in batch()"tc/tc.c+3 -10 replies
2/4Revert "tc: flush after each command in batch mode"tc/tc.c+0 -10 replies
3/4Revert "tc: fix batch force option"tc/tc.c+8 -110 replies
4/4Revert "tc: Add batchsize feature for filter and actions"tc/m_action.c tc/tc.c tc/tc_common.h +1 more+87 -3130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC iproute2 0/4] Revert tc batchsize feature

The batchsize feature of tc might save a few cycles but it is a maintaince nightmare, it has uninitialized variables and poor error handling.

This patch set reverts back to the original state. Please don't resubmit original code. Go back to the drawing board and do something generic. For example, the routing daemons have figured out that by using multiple threads and turning off the netlink ACK they can update millions of routes quickly.

Stephen Hemminger (4):
Revert "tc: Remove pointless assignments in batch()" Revert "tc: flush after each command in batch mode" Revert "tc: fix batch force option"
Revert "tc: Add batchsize feature for filter and actions"

 tc/m_action.c  |  65 ++++++----------
 tc/tc.c        | 201 ++++---------------------------------------------
 tc/tc_common.h |   7 +-
 tc/tc_filter.c | 129 ++++++++++++-------------------
 4 files changed, 87 insertions(+), 315 deletions(-)