RFC Revert tc batchsize feature
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Revert "tc: Remove pointless assignments in batch()"tc/ | +3 | 0 replies | |
| 2/4 | Revert "tc: flush after each command in batch mode"tc/ | +0 | 0 replies | |
| 3/4 | Revert "tc: fix batch force option"tc/ | +8 | 0 replies | |
| 4/4 | Revert "tc: Add batchsize feature for filter and actions"tc/ tc/ tc/ +1 more | +87 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC iproute2 0/4] Revert tc batchsize feature
The batchsize feature of tc might save a few cycles but it is a maintaince nightmare, it has uninitialized variables and poor error handling.
This patch set reverts back to the original state. Please don't resubmit original code. Go back to the drawing board and do something generic. For example, the routing daemons have figured out that by using multiple threads and turning off the netlink ACK they can update millions of routes quickly.
Stephen Hemminger (4):
Revert "tc: Remove pointless assignments in batch()" Revert "tc: flush after each command in batch mode" Revert "tc: fix batch force option"
Revert "tc: Add batchsize feature for filter and actions"
tc/m_action.c | 65 ++++++---------- tc/tc.c | 201 ++++--------------------------------------------- tc/tc_common.h | 7 +- tc/tc_filter.c | 129 ++++++++++++------------------- 4 files changed, 87 insertions(+), 315 deletions(-)