Skip to content

arm64: Stolen time support

Steven Price kvm kvmarm linux-arm-kernel linux-doc lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest10 patches 5 repliesIn review
  2. v610 patches 18 repliesSuperseded
  3. v510 patches 8 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v410 patches18 repliesSuperseded
v310 patches25 repliesSuperseded
v29 patches2 repliesSuperseded
v19 patches38 repliesSuperseded

Changes in v7 from the cover letter

https://lore.kernel.org/kvm/[email protected]/
* Rebased onto Mark Rutland's SMCCC cleanup
* Added comment about putting stolen time structures in their own 64k page
* Split 'init' functionality out from kvm_update_stolen_time()
* Enforce address provided by user space for structure is in a valid memslot
* Rename functions/structures in paravirt.c to avoid 'KVM' since the functionality isn't specific to KVM
* Minor cleanups from review comments

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10KVM: arm64: Document PV-time interfaceDocumentation/virt/kvm/arm/pvtime.rst Documentation/virt/kvm/devices/vcpu.txt+95 -00 replies
2/10KVM: arm/arm64: Factor out hypercall handling from PSCI codearch/arm/kvm/Makefile arch/arm/kvm/handle_exit.c arch/arm64/kvm/Makefile +6 more+112 -870 replies
3/10KVM: arm64: Implement PV_TIME_FEATURES callarch/arm/include/asm/kvm_host.h arch/arm64/include/asm/kvm_host.h arch/arm64/include/asm/pvclock-abi.h +4 more+68 -10 replies
4/10KVM: Implement kvm_put_guest()include/linux/kvm_host.h+22 -00 replies
5/10KVM: arm64: Support stolen time reporting via shared structurearch/arm/include/asm/kvm_host.h arch/arm64/include/asm/kvm_host.h arch/arm64/kvm/Kconfig +4 more+110 -00 replies
6/10KVM: Allow kvm_device_ops to be constinclude/linux/kvm_host.h virt/kvm/kvm_main.c+5 -50 replies
7/10KVM: arm64: Provide VCPU attributes for stolen timearch/arm64/include/asm/kvm_host.h arch/arm64/include/uapi/asm/kvm.h arch/arm64/kvm/guest.c +2 more+79 -00 replies
8/10arm/arm64: Provide a wrapper for SMCCC 1.1 callsinclude/linux/arm-smccc.h+45 -00 replies
9/10arm/arm64: Make use of the SMCCC 1.1 wrapperarch/arm/mm/proc-v7-bugs.c arch/arm64/kernel/cpu_errata.c+34 -601 reply
10/10arm64: Retrieve stolen time as paravirtualized guestDocumentation/admin-guide/kernel-parameters.txt arch/arm64/include/asm/paravirt.h arch/arm64/kernel/paravirt.c +2 more+155 -41 reply

Reviews trailers per patch

5 of 10 patches have a Reviewed-by or Acked-by.

PatchAndrew JonesWill DeaconCatalin Marinas
1/10
2/10R-b
3/10
4/10
5/10
6/10R-b
7/10
8/10A-b
9/10A-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/10] arm64: Stolen time support

This series add support for paravirtualized time for arm64 guests and KVM hosts following the specification in Arm's document DEN 0057A:

https://developer.arm.com/docs/den0057/a

It implements support for stolen time, allowing the guest to identify time when it is forcibly not executing.

Note that Live Physical Time (LPT) which was previously part of the above specification has now been removed.

Also available as a git tree:
git://linux-arm.org/linux-sp.git stolen_time/v7

Changes from v6:
https://lore.kernel.org/kvm/[email protected]/
* Rebased onto Mark Rutland's SMCCC cleanup
* Added comment about putting stolen time structures in their own 64k page
* Split 'init' functionality out from kvm_update_stolen_time()
* Enforce address provided by user space for structure is in a valid memslot
* Rename functions/structures in paravirt.c to avoid 'KVM' since the functionality isn't specific to KVM
* Minor cleanups from review comments

Changes from v5:
https://lore.kernel.org/kvm/[email protected]/
* Convert document to RST format
* Rename PV_FEATURES to PV_TIME_FEATURES to match spec
* Correct SMC number of PV_TIME_ST

Changes from v4:
https://lore.kernel.org/kvm/[email protected]/
* Rebased to v5.4-rc1
* Renamed KVM_ARM_VCPU_PVTIME_SET_IPA to remove _SET as it is used for both set/get operations
* Added kvm/arm_hypercalls.h to header-test-$(CONFIG_ARM{,64}) as it is only buildable on arm/arm64
* Documented no-steal-acc kernel parameter

Changes from v3:
https://lore.kernel.org/lkml/[email protected]/
* There's no longer a PV_TIME device, instead there are attributes on the VCPU. This allows the stolen time structures to be places arbitrarily by user space (subject to 64 byte alignment).
* Split documentation between information on the hypercalls and the attributes on the VCPU
* Fixed the type of SMCCC functions to return long not int

Changes from v2:
https://lore.kernel.org/lkml/[email protected]/
* Switched from using gfn_to_hva_cache to a new macro kvm_put_guest() that can provide the single-copy atomicity required (on arm64). This macro is added in patch 4.
* Tidied up the locking for kvm_update_stolen_time(). pagefault_disable() was unnecessary and the caller didn't need to take kvm->srcu as the function does it itself.
* Removed struct kvm_arch_pvtime from the arm implementation, replaced instead with inline static functions which are empty for arm.
* Fixed a few checkpatch --strict warnings.

Changes from v1:
https://lore.kernel.org/lkml/[email protected]/
* Host kernel no longer allocates the stolen time structure, instead it is allocated by user space. This means the save/restore functionality can be removed.
* Refactored the code so arm has stub implementations and to avoid initcall
* Rebased to pick up Documentation/{virt->virtual} change
* Bunch of typo fixes

Christoffer Dall (1):
KVM: arm/arm64: Factor out hypercall handling from PSCI code

Steven Price (9):
KVM: arm64: Document PV-time interface
KVM: arm64: Implement PV_TIME_FEATURES call
KVM: Implement kvm_put_guest()
KVM: arm64: Support stolen time reporting via shared structure
KVM: Allow kvm_device_ops to be const
KVM: arm64: Provide VCPU attributes for stolen time arm/arm64: Provide a wrapper for SMCCC 1.1 calls arm/arm64: Make use of the SMCCC 1.1 wrapper
arm64: Retrieve stolen time as paravirtualized guest

 .../admin-guide/kernel-parameters.txt         |   6 +-
 Documentation/virt/kvm/arm/pvtime.rst         |  81 ++++++++++
 Documentation/virt/kvm/devices/vcpu.txt       |  14 ++
 arch/arm/include/asm/kvm_host.h               |  25 ++++
 arch/arm/kvm/Makefile                         |   2 +-
 arch/arm/kvm/handle_exit.c                    |   2 +-
 arch/arm/mm/proc-v7-bugs.c                    |  13 +-
 arch/arm64/include/asm/kvm_host.h             |  29 ++++
 arch/arm64/include/asm/paravirt.h             |   9 +-
 arch/arm64/include/asm/pvclock-abi.h          |  17 +++
 arch/arm64/include/uapi/asm/kvm.h             |   2 +
 arch/arm64/kernel/cpu_errata.c                |  81 ++++------
 arch/arm64/kernel/paravirt.c                  | 140 ++++++++++++++++++
 arch/arm64/kernel/time.c                      |   3 +
 arch/arm64/kvm/Kconfig                        |   1 +
 arch/arm64/kvm/Makefile                       |   2 +
 arch/arm64/kvm/guest.c                        |   9 ++
 arch/arm64/kvm/handle_exit.c                  |   4 +-
 include/Kbuild                                |   2 +
 include/kvm/arm_hypercalls.h                  |  43 ++++++
 include/kvm/arm_psci.h                        |   2 +-
 include/linux/arm-smccc.h                     |  59 ++++++++
 include/linux/cpuhotplug.h                    |   1 +
 include/linux/kvm_host.h                      |  26 +++-
 include/linux/kvm_types.h                     |   2 +
 include/uapi/linux/kvm.h                      |   2 +
 virt/kvm/arm/arm.c                            |  11 ++
 virt/kvm/arm/hypercalls.c                     |  71 +++++++++
 virt/kvm/arm/psci.c                           |  84 +----------
 virt/kvm/arm/pvtime.c                         | 131 ++++++++++++++++
 virt/kvm/kvm_main.c                           |   6 +-
 31 files changed, 724 insertions(+), 156 deletions(-)
 create mode 100644 Documentation/virt/kvm/arm/pvtime.rst
 create mode 100644 arch/arm64/include/asm/pvclock-abi.h
 create mode 100644 include/kvm/arm_hypercalls.h
 create mode 100644 virt/kvm/arm/hypercalls.c
 create mode 100644 virt/kvm/arm/pvtime.c
Signature · 1 line
2.20.1