jbd2: Bit spinlock conversions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 5 repliesIn review
- v17 patches 2 repliesSuperseded
Changes in v2 from the cover letter
* Fixed up compilation breakage on UP due to missing linux/spinlock.h include
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | jbd2: Simplify journal_unmap_buffer()fs/ | +2 | 0 replies | |
| 2/7 | jbd2: Remove jbd_trylock_bh_state()include/ | +0 | 0 replies | |
| 3/7 | jbd2: Move dropping of jh reference out of un/re-filing functionsfs/ fs/ include/ | +20 | 0 replies | |
| 4/7 | jbd2: Drop unnecessary branch from jbd2_journal_forget()fs/ | +0 | 0 replies | |
| 5/7 | jbd2: Don't call __bforget() unnecessarilyfs/ | +4 | 3 replies | |
| 6/7 | jbd2: Make state lock a spinlockfs/ fs/ fs/ +3 more | +84 | 0 replies | |
| 7/7 | jbd2: Free journal head outside of locked regionfs/ | +14 | 0 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Jan Kara |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7 v2] jbd2: Bit spinlock conversions
Hello,
This series is derived from Thomas' series to get rid of bit spinlocks in buffer head code. These patches convert BH_State bit spinlock to an ordinary spinlock inside struct journal_head and somewhat reduce the critical section under BH_JournalHead bit spinlock so that it is fine for RT.
Motivation from original Thomas' series:
Bit spinlocks are problematic if PREEMPT_RT is enabled. They disable preemption, which is undesired for latency reasons and breaks when regular spinlocks are taken within the bit_spinlock locked region because regular spinlocks are converted to 'sleeping spinlocks' on RT.
Bit spinlocks are also not covered by lock debugging, e.g. lockdep. With the spinlock substitution in place, they can be exposed via a new config
switch: CONFIG_DEBUG_BIT_SPINLOCKS.
Ted, can you pick up these patches? Thanks!
Changes since v1:
* Fixed up compilation breakage on UP due to missing linux/spinlock.h include
Honza