Skip to content

libxl refactoring to use ev_qmp (with API changes)

Anthony PERARD xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest35 patches 5 repliesIn review
  2. v135 patches 54 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/35libxl: Make libxl_domain_unpause asynctools/libxl/libxl.h tools/libxl/libxl_colo_restore.c tools/libxl/libxl_colo_save.c +6 more+76 -280 replies
2/35libxl: Make libxl_send_trigger asynctools/libxl/libxl.h tools/libxl/libxl_domain.c tools/xl/xl_misc.c +1 more+24 -90 replies
3/35libxl: Make libxl_set_vcpuonline asynctools/libxl/libxl.h tools/libxl/libxl_domain.c tools/xl/xl_cpupool.c +1 more+24 -70 replies
4/35libxl: Make libxl_retrieve_domain_configuration asynctools/libxl/libxl.h tools/libxl/libxl_domain.c tools/xl/xl_info.c +2 more+25 -110 replies
5/35libxl: Make libxl_qemu_monitor_command asynctools/libxl/libxl.h tools/libxl/libxl_qmp.c tools/xl/xl_misc.c+19 -60 replies
6/35libxl: Use ev_qmp for switch_qemu_xen_logdirtytools/libxl/libxl_dom_save.c tools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+38 -161 reply
7/35libxl: Move "qmp_initializations" to libxl_dmtools/libxl/libxl_create.c tools/libxl/libxl_dm.c+8 -100 replies
8/35libxl: Replace libxl__qmp_initializations by ev_qmp callstools/libxl/libxl_dm.c tools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+212 -1760 replies
9/35libxl: Deprecate libxl__domain_{unpause, resume}tools/libxl/libxl_colo_restore.c tools/libxl/libxl_colo_save.c tools/libxl/libxl_dm.c +4 more+21 -170 replies
10/35libxl: Re-introduce libxl__domain_resumetools/libxl/libxl_dom_suspend.c tools/libxl/libxl_internal.h+219 -00 replies
11/35libxl_domain: Convert libxl_domain_resume to use libxl__domain_resumetools/libxl/libxl_domain.c+19 -20 replies
12/35libxl: Re-introduce libxl__domain_unpausetools/libxl/libxl_domain.c tools/libxl/libxl_internal.h+56 -10 replies
13/35libxl_dm: Update libxl__spawn_stub_dm to use libxl__domain_unpausetools/libxl/libxl_dm.c tools/libxl/libxl_internal.h+22 -10 replies
14/35libxl_domain: Convert libxl_domain_unpause to use libxl__domain_unpausetools/libxl/libxl_domain.c+18 -70 replies
15/35libxl: Inline do_usbdev_add into libxl__device_usbdev_addtools/libxl/libxl_usb.c+53 -680 replies
16/35libxl: Inline do_usbdev_remove into libxl__device_usbdev_removetools/libxl/libxl_usb.c+23 -400 replies
17/35libxl: Add libxl__ev_qmp to libxl__ao_devicetools/libxl/libxl_device.c tools/libxl/libxl_internal.h+7 -00 replies
18/35libxl: Add device_{config, type} to libxl__ao_devicetools/libxl/libxl_internal.h+6 -00 replies
19/35libxl_usb: Make libxl__device_usbctrl_add uses ev_qmptools/libxl/libxl_usb.c+77 -160 replies
20/35libxl_usb: Make libxl__initiate_device_usbctrl_remove uses ev_qmptools/libxl/libxl_usb.c+79 -180 replies
21/35libxl_usb: Make libxl__device_usbdev_add uses ev_qmptools/libxl/libxl_usb.c+81 -180 replies
22/35libxl: Use aodev for libxl__device_usbdev_removetools/libxl/libxl_usb.c+61 -180 replies
23/35libxl: libxl__initiate_device_usbdev_remove now use ev_qmptools/libxl/libxl_usb.c+68 -100 replies
24/35libxl: Remove libxl__qmp_run_command_flexarraytools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+0 -190 replies
25/35libxl_pci: Coding style of do_pci_addtools/libxl/libxl_pci.c+46 -330 replies
26/35libxl_pci: Only check if qemu-dm is running in qemu-trad casetools/libxl/libxl_pci.c+8 -90 replies
27/35libxl_pci: Use libxl__ao_device with libxl__device_pci_addtools/libxl/libxl_internal.h tools/libxl/libxl_pci.c+150 -270 replies
28/35libxl_pci: Use ev_qmp in do_pci_addtools/libxl/libxl_internal.h tools/libxl/libxl_pci.c tools/libxl/libxl_qmp.c+265 -1200 replies
29/35libxl_pci: Use libxl__ao_device with pci_removetools/libxl/libxl_domain.c tools/libxl/libxl_internal.h tools/libxl/libxl_pci.c+210 -660 replies
30/35libxl_pci: Use ev_qmp for pci_removetools/libxl/libxl_internal.h tools/libxl/libxl_pci.c tools/libxl/libxl_qmp.c+210 -910 replies
31/35libxl: Use ev_qmp for libxl_send_triggertools/libxl/libxl_domain.c tools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+42 -140 replies
32/35libxl: Use ev_qmp in libxl_set_vcpuonlinetools/libxl/libxl_domain.c tools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+158 -570 replies
33/35libxl: libxl_retrieve_domain_configuration now uses ev_qmptools/libxl/libxl_domain.c tools/libxl/libxl_internal.h tools/libxl/libxl_qmp.c+131 -730 replies
34/35libxl: libxl_qemu_monitor_command now uses ev_qmptools/libxl/libxl_qmp.c+50 -20 replies
35/35libxl_pci: Extract common part of *qemu_trad_watch_state_cbtools/libxl/libxl_pci.c+29 -221 reply

Reviews trailers per patch

34 of 35 patches have a Reviewed-by or Acked-by.

PatchIan Jackson
1/35A-b
2/35A-b
3/35A-b
4/35A-b
5/35A-b
6/35A-b
7/35A-b
8/35A-b
9/35A-b
10/35A-b
11/35A-b
12/35A-b
13/35A-b
14/35A-b
15/35A-b
16/35A-b
17/35A-b
18/35A-b
19/35A-b
20/35A-b
21/35A-b
22/35A-b
23/35A-b
24/35A-b
25/35A-b
26/35A-b
27/35A-b
28/35A-b
29/35A-b
30/35A-b
31/35A-b
32/35
33/35A-b
34/35A-b
35/35A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Xen-devel] [PATCH v2 00/35] libxl refactoring to use ev_qmp (with API changes)

Patches with missing ackes:
libxl: Use ev_qmp for switch_qemu_xen_logdirty
libxl: Use ev_qmp in libxl_set_vcpuonline
libxl_pci: Extract common part of *qemu_trad_watch_state_cb

The series depends on "Some cleanup of libxl" series.
Patch series available in this git branch (which is on top of the branch br.libxl-cleanup-v2):
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.libxl-ev_qmp-refactoring-v2

Hi,

On the quest to have QEMU depriviledge, we need to make quite a few changes to libxl. This patch series rework quite a few libxl feature to use libxl__ev_qmp, which is the new asynchronous way of communicating with QEMU in libxl.

Unfortunately, some libxl functions (in the public API) are supposed to be synchronous but are communicating with QEMU before returning. So those functions are made asynchronous with an additional parameter `libxl_asyncop_how'.

% libxl API changes

Functions that are changes:
- libxl_domain_unpause
- libxl_domain_pause
- libxl_send_trigger
- libxl_set_vcpuonline
- libxl_retrieve_domain_configuration
- libxl_qemu_monitor_command

% Patch series dependency

This series depends on:
- [PATCH 00/15] Some cleanup of libxl
(its v2)

Cheers,

Anthony PERARD (35):
libxl: Make libxl_domain_unpause async
libxl: Make libxl_send_trigger async
libxl: Make libxl_set_vcpuonline async
libxl: Make libxl_retrieve_domain_configuration async
libxl: Make libxl_qemu_monitor_command async
libxl: Use ev_qmp for switch_qemu_xen_logdirty
libxl: Move "qmp_initializations" to libxl_dm
libxl: Replace libxl__qmp_initializations by ev_qmp calls
libxl: Deprecate libxl__domain_{unpause,resume}
libxl: Re-introduce libxl__domain_resume
libxl_domain: Convert libxl_domain_resume to use libxl__domain_resume
libxl: Re-introduce libxl__domain_unpause
libxl_dm: Update libxl__spawn_stub_dm to use libxl__domain_unpause
libxl_domain: Convert libxl_domain_unpause to use
libxl__domain_unpause
libxl: Inline do_usbdev_add into libxl__device_usbdev_add
libxl: Inline do_usbdev_remove into libxl__device_usbdev_remove
libxl: Add libxl__ev_qmp to libxl__ao_device
libxl: Add device_{config,type} to libxl__ao_device
libxl_usb: Make libxl__device_usbctrl_add uses ev_qmp
libxl_usb: Make libxl__initiate_device_usbctrl_remove uses ev_qmp
libxl_usb: Make libxl__device_usbdev_add uses ev_qmp
libxl: Use aodev for libxl__device_usbdev_remove
libxl: libxl__initiate_device_usbdev_remove now use ev_qmp
libxl: Remove libxl__qmp_run_command_flexarray
libxl_pci: Coding style of do_pci_add
libxl_pci: Only check if qemu-dm is running in qemu-trad case
libxl_pci: Use libxl__ao_device with libxl__device_pci_add
libxl_pci: Use ev_qmp in do_pci_add
libxl_pci: Use libxl__ao_device with pci_remove
libxl_pci: Use ev_qmp for pci_remove
libxl: Use ev_qmp for libxl_send_trigger
libxl: Use ev_qmp in libxl_set_vcpuonline
libxl: libxl_retrieve_domain_configuration now uses ev_qmp
libxl: libxl_qemu_monitor_command now uses ev_qmp
libxl_pci: Extract common part of *qemu_trad_watch_state_cb

 tools/libxl/libxl.h              |  92 ++-
 tools/libxl/libxl_colo_restore.c |   4 +-
 tools/libxl/libxl_colo_save.c    |   4 +-
 tools/libxl/libxl_create.c       |  10 -
 tools/libxl/libxl_device.c       |   2 +
 tools/libxl/libxl_dm.c           | 239 +++++++-
 tools/libxl/libxl_dom_save.c     |  41 +-
 tools/libxl/libxl_dom_suspend.c  | 198 ++++++-
 tools/libxl/libxl_domain.c       | 627 ++++++++++++++++----
 tools/libxl/libxl_internal.h     |  90 ++-
 tools/libxl/libxl_pci.c          | 976 ++++++++++++++++++++++++++-----
 tools/libxl/libxl_qmp.c          | 471 ++-------------
 tools/libxl/libxl_remus.c        |   2 +-
 tools/libxl/libxl_usb.c          | 598 +++++++++++++------
 tools/xl/xl_cpupool.c            |   2 +-
 tools/xl/xl_info.c               |   3 +-
 tools/xl/xl_migrate.c            |   4 +-
 tools/xl/xl_misc.c               |   6 +-
 tools/xl/xl_saverestore.c        |   5 +-
 tools/xl/xl_vcpu.c               |   2 +-
 tools/xl/xl_vmcontrol.c          |  13 +-
 21 files changed, 2456 insertions(+), 933 deletions(-)
Signature · 7 lines
Anthony PERARD


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel