Skip to content

Fixes for SJA1105 DSA: FDBs, Learning and PTP

Vladimir Oltean netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: dsa: sja1105: Fix broken learning with vlan_filtering disableddrivers/net/dsa/sja1105/sja1105_main.c+55 -660 replies
2/5net: dsa: sja1105: Use the LOCKEDS bit for SJA1105 E/T as welldrivers/net/dsa/sja1105/sja1105_dynamic_config.c drivers/net/dsa/sja1105/sja1105_main.c+13 -160 replies
3/5net: dsa: sja1105: Really fix panic on unregistering PTP clockdrivers/net/dsa/sja1105/sja1105_main.c drivers/net/dsa/sja1105/sja1105_ptp.c+5 -60 replies
4/5net: dsa: sja1105: Fix memory leak on meta state machine normal pathnet/dsa/tag_sja1105.c+1 -100 replies
5/5net: dsa: sja1105: Fix memory leak on meta state machine error pathnet/dsa/tag_sja1105.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/5] Fixes for SJA1105 DSA: FDBs, Learning and PTP

This is an assortment of functional fixes for the sja1105 switch driver targeted for the "net" tree (although they apply on net-next just as well).

Patch 1/5 ("net: dsa: sja1105: Fix broken learning with vlan_filtering disabled") repairs a breakage introduced in the early development stages of the driver: support for traffic from the CPU has broken "normal" frame forwarding (based on DMAC) - there is connectivity through the switch only because all frames are flooded.
I debated whether this patch qualifies as a fix, since it puts the switch into a mode it has never operated in before (aka SVL). But "normal" forwarding did use to work before the "Traffic support for SJA1105 DSA driver" patchset, and arguably this patch should have been part of that.
Also, it would be strange for this feature to be broken in the 5.2 LTS.

Patch 2/5 ("net: dsa: sja1105: Use the LOCKEDS bit for SJA1105 E/T as well") is a simplification of a previous FDB-related patch that is currently in the 5.3 rc's.

Patches 3/5 - 5/5 fix various crashes found while running linuxptp over the switch ports for extended periods of time, or in conjunction with other error conditions. The fixed-up commits were all introduced in 5.2.

Vladimir Oltean (5):
net: dsa: sja1105: Fix broken learning with vlan_filtering disabled
net: dsa: sja1105: Use the LOCKEDS bit for SJA1105 E/T as well
net: dsa: sja1105: Really fix panic on unregistering PTP clock
net: dsa: sja1105: Fix memory leak on meta state machine normal path
net: dsa: sja1105: Fix memory leak on meta state machine error path

 .../net/dsa/sja1105/sja1105_dynamic_config.c  |  14 +-
 drivers/net/dsa/sja1105/sja1105_main.c        | 140 +++++++-----------
 drivers/net/dsa/sja1105/sja1105_ptp.c         |   7 +-
 net/dsa/tag_sja1105.c                         |  12 +-
 4 files changed, 75 insertions(+), 98 deletions(-)
Signature · 1 line
2.17.1