Skip to content

sitnl follow-up

Antonio Quartulli openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest6 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sitnl: harden strncpy() by forcing arguments to have the same lengthsrc/openvpn/networking_sitnl.c src/openvpn/route.h+6 -23 replies
2/6networking/best_gw: remove useless prefixlen parametersrc/openvpn/networking.h src/openvpn/networking_iproute2.c src/openvpn/networking_sitnl.c +1 more+15 -201 reply
3/6networking: extend API for better memory managementsrc/openvpn/networking.h src/openvpn/networking_iproute2.c src/openvpn/networking_iproute2.h +4 more+82 -453 replies
4/6tun.c: undo_ifconfig_ipv4/6 remove useless gc argumentsrc/openvpn/tun.c+10 -131 reply
5/6networking_sitnl.c: uncrustify filesrc/openvpn/networking_sitnl.c+43 -191 reply
6/6route.c: simplify ifdef logicsrc/openvpn/route.c+9 -111 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchGert Doering
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/6] sitnl follow-up

From: Antonio Quartulli <[email protected]...>

Hi all,

this small patchset aims at tackling most of the concerns raised by Gert while merging the sitnl introduction patchset.

All patches are fairly small, but they are a bit intertwined (they change nearby lines), therefore it would be better to merge them in the provided order to avoid ugly merge conflicts.

Cheers,

Antonio Quartulli (6):
sitnl: harden strncpy() by forcing arguments to have the same length networking/best_gw: remove useless prefixlen parameter
networking: extend API for better memory management tun.c: undo_ifconfig_ipv4/6 remove useless gc argument networking_sitnl.c: uncrustify file
route.c: simplify ifdef logic

 src/openvpn/networking.h          | 33 +++++++++--
 src/openvpn/networking_iproute2.c | 78 ++++++++++---------------
 src/openvpn/networking_iproute2.h |  1 +
 src/openvpn/networking_sitnl.c    | 96 +++++++++++++++++++++----------
 src/openvpn/openvpn.c             |  1 +
 src/openvpn/route.c               | 32 ++++++-----
 src/openvpn/route.h               |  6 +-
 src/openvpn/tun.c                 | 28 ++++-----
 8 files changed, 165 insertions(+), 110 deletions(-)
Signature · 1 line
2.22.0